diff --git a/rostests/apitests/w32knapi/ntgdi/NtGdiDeleteObjectApp.c b/rostests/apitests/w32knapi/ntgdi/NtGdiDeleteObjectApp.c index d4ac30b3825..ef4daa228bd 100644 --- a/rostests/apitests/w32knapi/ntgdi/NtGdiDeleteObjectApp.c +++ b/rostests/apitests/w32knapi/ntgdi/NtGdiDeleteObjectApp.c @@ -5,12 +5,10 @@ Test_NtGdiDeleteObjectApp(PTESTINFO pti) HDC hdc; HBITMAP hbmp; HBRUSH hbrush; - BOOL ret; /* Try to delete 0 */ SetLastError(0); - ret = NtGdiDeleteObjectApp(0); - TEST(ret == 0); + TEST(NtGdiDeleteObjectApp(0) == 0); TEST(GetLastError() == 0); /* Try to delete something with a stockbit */ @@ -21,40 +19,32 @@ Test_NtGdiDeleteObjectApp(PTESTINFO pti) /* Delete a DC */ SetLastError(0); hdc = CreateCompatibleDC(NULL); - ASSERT(hdc); - TEST(IsHandleValid(hdc) == 1); - ret = NtGdiDeleteObjectApp(hdc); - TEST(ret == 1); + ASSERT(IsHandleValid(hdc) == 1); + TEST(NtGdiDeleteObjectApp(hdc) == 1); TEST(GetLastError() == 0); TEST(IsHandleValid(hdc) == 0); /* Delete a brush */ SetLastError(0); hbrush = CreateSolidBrush(0x123456); - ASSERT(hbrush); - TEST(IsHandleValid(hbrush) == 1); - ret = NtGdiDeleteObjectApp(hbrush); - TEST(ret == 1); + ASSERT(IsHandleValid(hbrush) == 1); + TEST(NtGdiDeleteObjectApp(hbrush) == 1); TEST(GetLastError() == 0); TEST(IsHandleValid(hbrush) == 0); /* Try to delete a stock brush */ SetLastError(0); hbrush = GetStockObject(BLACK_BRUSH); - ASSERT(hbrush); - TEST(IsHandleValid(hbrush) == 1); - ret = NtGdiDeleteObjectApp(hbrush); - TEST(ret == 1); + ASSERT(IsHandleValid(hbrush) == 1); + TEST(NtGdiDeleteObjectApp(hbrush) == 1); TEST(GetLastError() == 0); TEST(IsHandleValid(hbrush) == 1); /* Delete a bitmap */ SetLastError(0); hbmp = CreateBitmap(10, 10, 1, 1, NULL); - ASSERT(hbmp); - TEST(IsHandleValid(hbmp) == 1); - ret = NtGdiDeleteObjectApp(hbmp); - TEST(ret == 1); + ASSERT(IsHandleValid(hbmp) == 1); + TEST(NtGdiDeleteObjectApp(hbmp) == 1); TEST(GetLastError() == 0); TEST(IsHandleValid(hbmp) == 0); @@ -65,23 +55,19 @@ Test_NtGdiDeleteObjectApp(PTESTINFO pti) /* Try to delete a brush that is selected into a DC */ SetLastError(0); hbrush = CreateSolidBrush(0x123456); - ASSERT(hbrush); - TEST(IsHandleValid(hbrush) == 1); + ASSERT(IsHandleValid(hbrush) == 1); TEST(NtGdiSelectBrush(hdc, hbrush)); - ret = NtGdiDeleteObjectApp(hbrush); - TEST(ret == 1); + TEST(NtGdiDeleteObjectApp(hbrush) == 1); TEST(GetLastError() == 0); TEST(IsHandleValid(hbrush) == 1); /* Try to delete a bitmap that is selected into a DC */ SetLastError(0); hbmp = CreateBitmap(10, 10, 1, 1, NULL); - ASSERT(hbmp); - TEST(IsHandleValid(hbmp) == 1); + ASSERT(IsHandleValid(hbmp) == 1); TEST(NtGdiSelectBitmap(hdc, hbmp)); - ret = NtGdiDeleteObjectApp(hbmp); - TEST(ret == 1); + TEST(NtGdiDeleteObjectApp(hbmp) == 1); TEST(GetLastError() == 0); TEST(IsHandleValid(hbmp) == 1); @@ -89,11 +75,19 @@ Test_NtGdiDeleteObjectApp(PTESTINFO pti) NtGdiSelectBitmap(hdc, GetStockObject(DEFAULT_BITMAP)); TEST(IsHandleValid(hbmp) == 0); - ret = NtGdiDeleteObjectApp(hbmp); - TEST(ret == 1); + TEST(NtGdiDeleteObjectApp(hbmp) == 1); TEST(GetLastError() == 0); TEST(IsHandleValid(hbmp) == 0); + /* Try to delete a brush that is selected into a DC */ + SetLastError(0); + hbrush = CreateSolidBrush(123); + ASSERT(IsHandleValid(hbrush) == 1); + TEST(NtGdiSelectBrush(hdc, hbrush)); + + TEST(NtGdiDeleteObjectApp(hbrush) == 1); + TEST(GetLastError() == 0); + TEST(IsHandleValid(hbrush) == 1); return APISTATUS_NORMAL; }