Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-06-01 02:01:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

[NTOS:CM] Don't lazy flush the registry during unlocking operation

Browse source 
Whenever ReactOS finishes its operations onto the registry and unlocks it, a lazy flush is invoked to do an eventual flushing of the registry to the backing storage of the system. Except that... lazy flushing never comes into place.

This is because whenever CmpLazyFlush is called that sets up a timer which needs to expire in order to trigger the lazy flusher engine worker. However, registry locking/unlocking is a frequent occurrence, mainly when on desktop. Therefore as a matter of fact, CmpLazyFlush keeps removing and inserting the timer and the lazy flusher will never kick in that way.

Ironically the lazy flusher actually does the flushing when on USETUP installation phase because during text-mode setup installation in ReactOS the frequency of registry operations is actually less so the timer has the opportunity to expire and fire up the flusher.

In addition to that, we must queue a lazy flush when marking cells as dirty because such dirty data has to be flushed down to the media storage of the system. Of course, the real place where lazy flushing operation is done should be in a subset helper like HvMarkDirty that marks parts of a hive as dirty but since we do not have that, we'll be lazy flushing the registry during cells dirty marking instead for now.

CORE-18303
This commit is contained in:
George Bișoc 2022-12-22 22:12:55 +01:00
parent 1247a16863
commit 578f2fc512
No known key found for this signature in database
GPG key ID: 688C4FBE25D7DEF6
2 changed files with 28 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ntoskrnl/config/cmsysini.c
View file

@ -1956,11 +1956,6 @@ CmpUnlockRegistry(VOID)
CmpDoFlushAll(TRUE);
CmpFlushOnLockRelease = FALSE;
}
else
{
/* Lazy flush the registry */
CmpLazyFlush();
}
/* Release the lock and leave the critical region */
ExReleaseResourceLite(&CmpRegistryLock);

28
sdk/lib/cmlib/hivecell.c
View file

@ -9,6 +9,16 @@
#define NDEBUG
#include <debug.h>
/* DECLARATIONS *************************************************************/
#if !defined(CMLIB_HOST) && !defined(_BLDR_)
VOID
NTAPI
CmpLazyFlush(VOID);
#endif
/* FUNCTIONS *****************************************************************/
static __inline PHCELL CMAPI
HvpGetCellHeader(
PHHIVE RegistryHive,
@ -118,6 +128,24 @@ HvMarkCellDirty(
RtlSetBits(&RegistryHive->DirtyVector,
CellBlock, CellLastBlock - CellBlock);
RegistryHive->DirtyCount++;
/*
* FIXME: Querying a lazy flush operation is needed to
* ensure that the dirty data is being flushed to disk
* accordingly. However, this operation has to be done
* in a helper like HvMarkDirty that marks specific parts
* of the hive as dirty. Since we do not have such kind
* of helper we have to perform an eventual lazy flush
* when marking cells as dirty here for the moment being,
* so that not only we flush dirty data but also write
* logs.
*/
#if !defined(CMLIB_HOST) && !defined(_BLDR_)
if (!(RegistryHive->HiveFlags & HIVE_NOLAZYFLUSH))
{
CmpLazyFlush();
}
#endif
return TRUE;
}