Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-05 20:03:12 +00:00
Code Issues Projects Releases Packages Wiki Activity

[FREELDR] iso.c: Remove a redundant zero initialization of the FileName buffer (#7734)

Browse source 
The FileName buffer is NUL-terminated later on.
This commit is contained in:
Dmitry Borisov 2025-03-02 17:57:53 +06:00 • committed by Hermès Bélusca-Maïto
parent b931c51937
commit 564be44f45
No known key found for this signature in database
GPG key ID: 3B2539C65E7B93D0
1 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
boot/freeldr/freeldr/lib/fs/iso.c
View file

@ -46,8 +46,6 @@ static BOOLEAN IsoSearchDirectoryBufferForFile(PVOID DirectoryBuffer, ULONG Dire
TRACE("IsoSearchDirectoryBufferForFile() DirectoryBuffer = 0x%x DirectoryLength = %d FileName = %s\n", DirectoryBuffer, DirectoryLength, FileName); TRACE("IsoSearchDirectoryBufferForFile() DirectoryBuffer = 0x%x DirectoryLength = %d FileName = %s\n", DirectoryBuffer, DirectoryLength, FileName);
RtlZeroMemory(Name, 32 * sizeof(UCHAR));
Offset = 0; Offset = 0;
Record = (PDIR_RECORD)DirectoryBuffer; Record = (PDIR_RECORD)DirectoryBuffer;
while (TRUE) while (TRUE)
@ -76,7 +74,7 @@ static BOOLEAN IsoSearchDirectoryBufferForFile(PVOID DirectoryBuffer, ULONG Dire
{ {
for (i = 0; i < Record->FileIdLength && Record->FileId[i] != ';'; i++) for (i = 0; i < Record->FileIdLength && Record->FileId[i] != ';'; i++)
Name[i] = Record->FileId[i]; Name[i] = Record->FileId[i];
Name[i] = 0; Name[i] = ANSI_NULL;
TRACE("Name '%s'\n", Name); TRACE("Name '%s'\n", Name);
if (strlen(FileName) == strlen(Name) && _stricmp(FileName, Name) == 0) if (strlen(FileName) == strlen(Name) && _stricmp(FileName, Name) == 0)
@ -90,8 +88,6 @@ static BOOLEAN IsoSearchDirectoryBufferForFile(PVOID DirectoryBuffer, ULONG Dire
} }
} }
RtlZeroMemory(Name, 32 * sizeof(UCHAR));
} }
return FALSE; return FALSE;