Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-28 10:04:49 +00:00
Code Issues Projects Releases Packages Wiki Activity

- Don't try to get the length of a possibly empty string. This fixes many menu applications (such as WinRAR). However I'm now getting a bug due to a double-free. It seems a GDI Object is being freed twice. Can anyone check this out please?

Browse source 
svn path=/trunk/; revision=16728
This commit is contained in:
Alex Ionescu 2005-07-26 00:43:19 +00:00
parent e7c2fa1d9c
commit 55234f6094
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
reactos/lib/user32/windows/menu.c
View file

@ -3771,8 +3771,11 @@ GetMenuItemInfoA(
} }
RtlCopyMemory(mii, &miiW, miiW.cbSize); RtlCopyMemory(mii, &miiW, miiW.cbSize);
mii->dwTypeData = AnsiBuffer; if (AnsiBuffer)
mii->cch = strlen(AnsiBuffer); {
mii->dwTypeData = AnsiBuffer;
mii->cch = strlen(AnsiBuffer);
}
return TRUE; return TRUE;
} }