[FORMATTING] - Fix formatting in IoCreateFile

svn path=/trunk/; revision=22868

reactos/ntoskrnl/io/iomgr/file.c

@@ -795,76 +795,10 @@ IoCheckQuotaBufferValidity(IN PFILE_QUOTA_INFORMATION QuotaBuffer,
 }
 
 /*
- * NAME       EXPORTED
- *  IoCreateFile@56
- *
- * DESCRIPTION
- *  Either causes a new file or directory to be created, or it
- *  opens an existing file, device, directory or volume, giving
- *  the caller a handle for the file object. This handle can be
- *  used by subsequent calls to manipulate data within the file
- *  or the file object's state of attributes.
- *
- * ARGUMENTS
- * FileHandle (OUT)
- *  Points to a variable which receives the file handle
- *  on return;
- *
- * DesiredAccess
- *  Desired access to the file;
- *
- * ObjectAttributes
- *  Structure describing the file;
- *
- * IoStatusBlock (OUT)
- *  Receives information about the operation on return;
- *
- * AllocationSize [OPTIONAL]
- *  Initial size of the file in bytes;
- *
- * FileAttributes
- *  Attributes to create the file with;
- *
- * ShareAccess
- *  Type of shared access the caller would like to the
- *  file;
- *
- * CreateDisposition
- *  Specifies what to do, depending on whether the
- *  file already exists;
- *
- * CreateOptions
- *  Options for creating a new file;
- *
- * EaBuffer [OPTIONAL]
- *  Undocumented;
- *
- * EaLength
- *  Undocumented;
- *
- * CreateFileType
- *  Type of file (normal, named pipe, mailslot) to create;
- *
- * ExtraCreateParameters [OPTIONAL]
- *  Additional creation data for named pipe and mailsots;
- *
- * Options
- *  Undocumented.
- *
- * RETURN VALUE
- *  Status
- *
- * NOTE
- *  Prototype taken from Bo Branten's ntifs.h v15.
- *  Description taken from old NtCreateFile's which is
- *  now a wrapper of this call.
- *
- * REVISIONS
- *
  * @implemented
  */
 NTSTATUS
-STDCALL
+NTAPI
 IoCreateFile(OUT PHANDLE FileHandle,
              IN ACCESS_MASK DesiredAccess,
              IN POBJECT_ATTRIBUTES ObjectAttributes,
@@ -881,12 +815,11 @@ IoCreateFile(OUT PHANDLE  FileHandle,
              IN ULONG Options)
 {
     PFILE_OBJECT FileObject = NULL;
-   //PDEVICE_OBJECT DeviceObject;
     PIRP Irp;
     PEXTENDED_IO_STACK_LOCATION StackLoc;
     IO_SECURITY_CONTEXT SecurityContext;
     KPROCESSOR_MODE AccessMode;
-   HANDLE               LocalHandle;
+    HANDLE LocalHandle = 0;
     LARGE_INTEGER SafeAllocationSize;
     PVOID SystemEaBuffer = NULL;
     NTSTATUS  Status = STATUS_SUCCESS;
@@ -895,23 +828,16 @@ IoCreateFile(OUT PHANDLE  FileHandle,
     KIRQL OldIrql;
     PKNORMAL_ROUTINE NormalRoutine;
     PVOID NormalContext;
-
+    PAGED_CODE();
-   DPRINT("IoCreateFile(FileHandle 0x%p, DesiredAccess %x, "
-          "ObjectAttributes 0x%p ObjectAttributes->ObjectName->Buffer %S)\n",
-          FileHandle,DesiredAccess,ObjectAttributes,
-          ObjectAttributes->ObjectName->Buffer);
-
-   ASSERT_IRQL(PASSIVE_LEVEL);
-
-   if (IoStatusBlock == NULL || FileHandle == NULL)
-     return STATUS_ACCESS_VIOLATION;
-
-   LocalHandle = 0;
 
     if(Options & IO_NO_PARAMETER_CHECKING)
+    {
         AccessMode = KernelMode;
+    }
     else
+    {
         AccessMode = ExGetPreviousMode();
+    }
 
     if(AccessMode != KernelMode)
     {
@@ -921,31 +847,30 @@ IoCreateFile(OUT PHANDLE  FileHandle,
             ProbeForWrite(IoStatusBlock,
                           sizeof(IO_STATUS_BLOCK),
                           sizeof(ULONG));
-       if(AllocationSize != NULL)
+            if (AllocationSize)
             {
                 SafeAllocationSize = ProbeForReadLargeInteger(AllocationSize);
             }
             else
+            {
                 SafeAllocationSize.QuadPart = 0;
+            }
 
-       if(EaBuffer != NULL && EaLength > 0)
+            if ((EaBuffer) && (EaLength))
             {
                 ProbeForRead(EaBuffer,
                              EaLength,
                              sizeof(ULONG));
 
                 /* marshal EaBuffer */
-         SystemEaBuffer = ExAllocatePool(NonPagedPool,
+                SystemEaBuffer = ExAllocatePool(NonPagedPool, EaLength);
-                                         EaLength);
+                if(!SystemEaBuffer)
-         if(SystemEaBuffer == NULL)
                 {
                     Status = STATUS_INSUFFICIENT_RESOURCES;
                     _SEH_LEAVE;
                 }
 
-         RtlCopyMemory(SystemEaBuffer,
+                RtlCopyMemory(SystemEaBuffer, EaBuffer, EaLength);
-                       EaBuffer,
-                       EaLength);
             }
         }
         _SEH_HANDLE
@@ -954,22 +879,20 @@ IoCreateFile(OUT PHANDLE  FileHandle,
         }
         _SEH_END;
 
-     if(!NT_SUCCESS(Status))
+        if(!NT_SUCCESS(Status)) return Status;
-     {
-       return Status;
-     }
     }
     else
     {
-     if(AllocationSize != NULL)
+        if (AllocationSize)
+        {
             SafeAllocationSize = *AllocationSize;
-     else
-       SafeAllocationSize.QuadPart = 0;
-
-     if(EaBuffer != NULL && EaLength > 0)
-     {
-       SystemEaBuffer = EaBuffer;
         }
+        else
+        {
+            SafeAllocationSize.QuadPart = 0;
+        }
+
+        if ((EaBuffer) && (EaLength)) SystemEaBuffer = EaBuffer;
     }
 
     if(Options & IO_CHECK_CREATE_PARAMETERS)
@@ -987,7 +910,6 @@ IoCreateFile(OUT PHANDLE  FileHandle,
                                 DesiredAccess,
                                 NULL,
                                 &LocalHandle);
-
     ObReferenceObjectByHandle(LocalHandle,
                               DesiredAccess,
                               NULL,
@@ -999,10 +921,6 @@ IoCreateFile(OUT PHANDLE  FileHandle,
     FileObject->Type = IO_TYPE_FILE;
     FileObject->Size = sizeof(FILE_OBJECT);
 
-   //
-   // stop stuff that should be in IopParseDevice
-   //
-
     if (CreateOptions &
         (FILE_SYNCHRONOUS_IO_ALERT | FILE_SYNCHRONOUS_IO_NONALERT))
     {
@@ -1034,12 +952,8 @@ IoCreateFile(OUT PHANDLE  FileHandle,
     {
         FileObject->Flags |= FO_OPENED_CASE_SENSITIVE;
     }
-    /* 
-     * FIXME: We should get the access state from Ob once this function becomes
-     * a parse routine once the Ob is refactored.
-     */
-   SeCreateAccessState(&AccessState, &AuxData, FILE_ALL_ACCESS, NULL);
 
+    SeCreateAccessState(&AccessState, &AuxData, FILE_ALL_ACCESS, NULL);
     SecurityContext.SecurityQos = NULL; /* ?? */
     SecurityContext.AccessState = &AccessState;
     SecurityContext.DesiredAccess = DesiredAccess;
@@ -1048,15 +962,8 @@ IoCreateFile(OUT PHANDLE  FileHandle,
     KeInitializeEvent(&FileObject->Lock, SynchronizationEvent, TRUE);
     KeInitializeEvent(&FileObject->Event, NotificationEvent, FALSE);
 
-   DPRINT("FileObject 0x%p\n", FileObject);
-   DPRINT("FileObject->DeviceObject 0x%p\n", FileObject->DeviceObject);
-   /*
-    * Create a new IRP to hand to
-    * the FS driver: this may fail
-    * due to resource shortage.
-    */
     Irp = IoAllocateIrp(FileObject->DeviceObject->StackSize, FALSE);
-   if (Irp == NULL)
+    if (!Irp)
     {
         ZwClose(LocalHandle);
         return STATUS_UNSUCCESSFUL;
@@ -1078,10 +985,6 @@ IoCreateFile(OUT PHANDLE  FileHandle,
     Irp->CancelRoutine = NULL;
     Irp->Tail.Overlay.AuxiliaryBuffer = NULL;
 
-   /*
-    * Get the stack location for the new
-    * IRP and prepare it.
-    */
     StackLoc = (PEXTENDED_IO_STACK_LOCATION)IoGetNextIrpStackLocation(Irp);
     StackLoc->Control = 0;
     StackLoc->FileObject = FileObject;
@@ -1115,15 +1018,7 @@ IoCreateFile(OUT PHANDLE  FileHandle,
     StackLoc->Parameters.Create.ShareAccess = ShareAccess;
     StackLoc->Parameters.Create.SecurityContext = &SecurityContext;
 
-   /*
-    * Now call the driver and
-    * possibly wait if it can
-    * not complete the request
-    * immediately.
-    */
     Status = IofCallDriver(FileObject->DeviceObject, Irp );
-   DPRINT("Status :%x\n", Status);
-   
     if (Status == STATUS_PENDING)
     {
         KeWaitForSingleObject(&FileObject->Event,
@@ -1145,9 +1040,9 @@ IoCreateFile(OUT PHANDLE  FileHandle,
                            &NormalContext);
         KeLowerIrql(OldIrql);
     }
+
     if (!NT_SUCCESS(Status))
     {
-       DPRINT("Failing create request with status %x\n", Status);
         FileObject->DeviceObject = NULL;
         FileObject->Vpb = NULL;
         ObDereferenceObject(FileObject);
@@ -1166,15 +1061,11 @@ IoCreateFile(OUT PHANDLE  FileHandle,
     }
 
     /* cleanup EABuffer if captured */
-   if(AccessMode != KernelMode && SystemEaBuffer != NULL)
+    if (AccessMode != KernelMode && (SystemEaBuffer))
     {
         ExFreePool(SystemEaBuffer);
     }
 
-   ASSERT_IRQL(PASSIVE_LEVEL);
-
-   DPRINT("Finished IoCreateFile() (*FileHandle) 0x%p\n", (*FileHandle));
-
     return Status;
 }