Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-07 05:52:57 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NTOS:KD64] Some code formatting + add SAL2 annotations to the functions that are going to be involved in the next commit.

Browse source 
+ s/ReturnStatus/Status/ , and get rid of Win32 LPSTR and replace by
  PCHAR (since the concerned code deals with counted strings).
This commit is contained in:
Hermès Bélusca-Maïto 2019-11-17 22:28:42 +01:00
parent 6c1aac6948
commit 54c03f6965
No known key found for this signature in database
GPG key ID: 3B2539C65E7B93D0
5 changed files with 115 additions and 128 deletions
Download patch file Download diff file Expand all files Collapse all files

49
ntoskrnl/kd64/kdapi.c
View file

@ -17,9 +17,10 @@
VOID
NTAPI
KdpMoveMemory(IN PVOID Destination,
IN PVOID Source,
IN SIZE_T Length)
KdpMoveMemory(
_In_ PVOID Destination,
_In_ PVOID Source,
_In_ SIZE_T Length)
{
PCHAR DestinationBytes, SourceBytes;
@ -31,8 +32,9 @@ KdpMoveMemory(IN PVOID Destination,
VOID
NTAPI
KdpZeroMemory(IN PVOID Destination,
IN SIZE_T Length)
KdpZeroMemory(
_In_ PVOID Destination,
_In_ SIZE_T Length)
{
PCHAR DestinationBytes;
@ -43,12 +45,13 @@ KdpZeroMemory(IN PVOID Destination,
NTSTATUS
NTAPI
KdpCopyMemoryChunks(IN ULONG64 Address,
IN PVOID Buffer,
IN ULONG TotalSize,
IN ULONG ChunkSize,
IN ULONG Flags,
OUT PULONG ActualSize OPTIONAL)
KdpCopyMemoryChunks(
_In_ ULONG64 Address,
_In_ PVOID Buffer,
_In_ ULONG TotalSize,
_In_ ULONG ChunkSize,
_In_ ULONG Flags,
_Out_opt_ PULONG ActualSize)
{
NTSTATUS Status;
ULONG RemainingLength, CopyChunk;
@ -94,10 +97,7 @@ KdpCopyMemoryChunks(IN ULONG64 Address,
}
/* Do the copy */
Status = MmDbgCopyMemory(Address,
Buffer,
CopyChunk,
Flags);
Status = MmDbgCopyMemory(Address, Buffer, CopyChunk, Flags);
if (!NT_SUCCESS(Status))
{
/* Copy failed, break out */
@ -2147,15 +2147,16 @@ KdDisableDebugger(VOID)
*/
NTSTATUS
NTAPI
KdSystemDebugControl(IN SYSDBG_COMMAND Command,
IN PVOID InputBuffer,
IN ULONG InputBufferLength,
OUT PVOID OutputBuffer,
IN ULONG OutputBufferLength,
IN OUT PULONG ReturnLength,
IN KPROCESSOR_MODE PreviousMode)
KdSystemDebugControl(
_In_ SYSDBG_COMMAND Command,
_In_ PVOID InputBuffer,
_In_ ULONG InputBufferLength,
_Out_ PVOID OutputBuffer,
_In_ ULONG OutputBufferLength,
_Inout_ PULONG ReturnLength,
_In_ KPROCESSOR_MODE PreviousMode)
{
/* handle sime internal commands */
/* Handle some internal commands */
if (Command == ' soR')
{
switch ((ULONG_PTR)InputBuffer)
@ -2269,7 +2270,7 @@ KdRefreshDebuggerNotPresent(VOID)
/* Check if the debugger is completely disabled */
if (KdPitchDebugger)
{
/* Don't try to refresh then -- fail early */
/* Don't try to refresh then, fail early */
return TRUE;
}