Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-28 10:04:49 +00:00
Code Issues Projects Releases Packages Wiki Activity

1. fixed the ProcessAccessToken information class to properly check buffers

Browse source 
2. implemented the ProcessExceptionPort information class

svn path=/trunk/; revision=13141
This commit is contained in:
Thomas Bluemel 2005-01-19 21:47:51 +00:00
parent 223c560590
commit 51e2ff7462
1 changed files with 94 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

99
reactos/ntoskrnl/ps/process.c
View file

@ -1458,7 +1458,6 @@ NtSetInformationProcess(IN HANDLE ProcessHandle,
{ {
PEPROCESS Process; PEPROCESS Process;
NTSTATUS Status; NTSTATUS Status;
PHANDLE ProcessAccessTokenP;
KPROCESSOR_MODE PreviousMode; KPROCESSOR_MODE PreviousMode;
PreviousMode = ExGetPreviousMode(); PreviousMode = ExGetPreviousMode();
@ -1480,14 +1479,104 @@ NtSetInformationProcess(IN HANDLE ProcessHandle,
case ProcessBasePriority: case ProcessBasePriority:
case ProcessRaisePriority: case ProcessRaisePriority:
case ProcessDebugPort: case ProcessDebugPort:
case ProcessExceptionPort:
Status = STATUS_NOT_IMPLEMENTED; Status = STATUS_NOT_IMPLEMENTED;
break; break;
case ProcessExceptionPort:
{
if(ProcessInformationLength != sizeof(PROCESS_ACCESS_TOKEN))
{
Status = STATUS_INFO_LENGTH_MISMATCH;
}
else
{
HANDLE PortHandle;
/* make a safe copy of the buffer on the stack */
_SEH_TRY
{
PortHandle = *(PHANDLE)ProcessInformation;
Status = STATUS_SUCCESS;
}
_SEH_HANDLE
{
Status = _SEH_GetExceptionCode();
}
_SEH_END;
if(NT_SUCCESS(Status))
{
PEPORT ExceptionPort;
/* in case we had success reading from the buffer, verify the provided
* LPC port handle
*/
Status = ObReferenceObjectByHandle(PortHandle,
0,
LpcPortObjectType,
PreviousMode,
(PVOID)&ExceptionPort,
NULL);
if(NT_SUCCESS(Status))
{
/* lock the process to be thread-safe! */
Status = PsLockProcess(Process, FALSE);
if(NT_SUCCESS(Status))
{
/*
* according to "NT Native API" documentation, setting the exception
* port is only permitted once!
*/
if(Process->ExceptionPort == NULL)
{
Process->ExceptionPort = ExceptionPort;
Status = STATUS_SUCCESS;
}
else
{
Status = STATUS_PORT_ALREADY_SET;
}
PsUnlockProcess(Process);
}
ObDereferenceObject(ExceptionPort);
}
}
}
break;
}
case ProcessAccessToken: case ProcessAccessToken:
ProcessAccessTokenP = (PHANDLE)ProcessInformation; {
Status = PspAssignPrimaryToken(Process, *ProcessAccessTokenP); if(ProcessInformationLength != sizeof(PROCESS_ACCESS_TOKEN))
{
Status = STATUS_INFO_LENGTH_MISMATCH;
}
else
{
HANDLE TokenHandle;
/* make a safe copy of the buffer on the stack */
_SEH_TRY
{
TokenHandle = ((PPROCESS_ACCESS_TOKEN)ProcessInformation)->Token;
Status = STATUS_SUCCESS;
}
_SEH_HANDLE
{
Status = _SEH_GetExceptionCode();
}
_SEH_END;
if(NT_SUCCESS(Status))
{
/* in case we had success reading from the buffer, perform the actual task */
Status = PspAssignPrimaryToken(Process, TokenHandle);
}
}
break; break;
}
case ProcessDefaultHardErrorMode: case ProcessDefaultHardErrorMode:
{ {
@ -1572,7 +1661,7 @@ NtSetInformationProcess(IN HANDLE ProcessHandle,
/* FIXME - update the session id for the process token */ /* FIXME - update the session id for the process token */
Status = PsLockProcess(Process, TRUE); Status = PsLockProcess(Process, FALSE);
if(NT_SUCCESS(Status)) if(NT_SUCCESS(Status))
{ {
Process->SessionId = SessionInfo.SessionId; Process->SessionId = SessionInfo.SessionId;