Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-04-06 05:34:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

[MSV1_0] Protect the logon list from concurrent access

Browse source
This commit is contained in:
Eric Kohl 2025-01-05 16:30:40 +01:00
parent b114e3a051
commit 4cdcbbd1a9
1 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
dll/win32/msv1_0/msv1_0.c
View file

@ -27,6 +27,7 @@ typedef struct _LOGON_LIST_ENTRY
BOOL PackageInitialized = FALSE;
LIST_ENTRY LogonListHead;
RTL_RESOURCE LogonListResource;
ULONG EnumCounter;
/* FUNCTIONS ***************************************************************/
@ -891,6 +892,8 @@ MsvpEnumerateUsers(
return STATUS_INVALID_PARAMETER;
}
RtlAcquireResourceShared(&LogonListResource, TRUE);
/* Count the currently logged-on users */
CurrentEntry = LogonListHead.Flink;
while (CurrentEntry != &LogonListHead)
@ -973,6 +976,8 @@ MsvpEnumerateUsers(
*ProtocolStatus = STATUS_SUCCESS;
done:
RtlReleaseResource(&LogonListResource);
if (LocalBuffer != NULL)
DispatchTable.FreeLsaHeap(LocalBuffer);
@ -1018,6 +1023,8 @@ MsvpGetUserInfo(
TRACE("LogonId: 0x%lx\n", RequestBuffer->LogonId.LowPart);
RtlAcquireResourceShared(&LogonListResource, TRUE);
LogonEntry = GetLogonByLogonId(&RequestBuffer->LogonId);
if (LogonEntry == NULL)
{
@ -1100,6 +1107,8 @@ MsvpGetUserInfo(
*ProtocolStatus = STATUS_SUCCESS;
done:
RtlReleaseResource(&LogonListResource);
if (LocalBuffer != NULL)
DispatchTable.FreeLsaHeap(LocalBuffer);
@ -1278,6 +1287,7 @@ LsaApInitializePackage(IN ULONG AuthenticationPackageId,
if (!PackageInitialized)
{
InitializeListHead(&LogonListHead);
RtlInitializeResource(&LogonListResource);
EnumCounter = 0;
PackageInitialized = TRUE;
}
@ -1333,7 +1343,9 @@ LsaApLogonTerminated(
LogonEntry = GetLogonByLogonId(LogonId);
if (LogonEntry != NULL)
{
RtlAcquireResourceExclusive(&LogonListResource, TRUE);
RemoveEntryList(&LogonEntry->ListEntry);
RtlReleaseResource(&LogonListResource);
if (LogonEntry->UserName.Buffer)
RtlFreeHeap(RtlGetProcessHeap(), 0, LogonEntry->UserName.Buffer);
@ -1702,7 +1714,9 @@ LsaApLogonUserEx2(IN PLSA_CLIENT_REQUEST ClientRequest,
LogonEntry->LogonType = LogonType;
RtlAcquireResourceExclusive(&LogonListResource, TRUE);
InsertTailList(&LogonListHead, &LogonEntry->ListEntry);
RtlReleaseResource(&LogonListResource);
}
if (LogonType == Interactive || LogonType == Batch || LogonType == Service)