From 4caf3913242a0c908c29e0cc34ea6464e8149f9d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Herm=C3=A8s=20B=C3=A9lusca-Ma=C3=AFto?= Date: Sun, 14 Oct 2018 01:20:31 +0200 Subject: [PATCH] [NTOS][MKHIVE] Minor code formatting. --- ntoskrnl/config/cmapi.c | 6 ++--- sdk/tools/mkhive/registry.c | 50 ++++++++++++++++++------------------- 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/ntoskrnl/config/cmapi.c b/ntoskrnl/config/cmapi.c index 85723d18815..3b476d8c8e3 100644 --- a/ntoskrnl/config/cmapi.c +++ b/ntoskrnl/config/cmapi.c @@ -982,7 +982,7 @@ CmDeleteValueKey(IN PCM_KEY_CONTROL_BLOCK Kcb, } /* Get the key value */ - Value = (PCM_KEY_VALUE)HvGetCell(Hive,ChildCell); + Value = (PCM_KEY_VALUE)HvGetCell(Hive, ChildCell); ASSERT(Value); /* Mark it and all related data as dirty */ @@ -1851,7 +1851,7 @@ CmDeleteKey(IN PCM_KEY_BODY KeyBody) { /* Don't do it twice */ Status = STATUS_SUCCESS; - goto Quickie2; + goto Quickie; } /* Get the hive and node */ @@ -1925,7 +1925,7 @@ CmDeleteKey(IN PCM_KEY_BODY KeyBody) CmpUnlockHiveFlusher((PCMHIVE)Hive); /* Release the KCB locks */ -Quickie2: +Quickie: CmpReleaseTwoKcbLockByKey(Kcb->ConvKey, Kcb->ParentKcb->ConvKey); /* Release hive lock */ diff --git a/sdk/tools/mkhive/registry.c b/sdk/tools/mkhive/registry.c index 17030bb2097..1686fca08da 100644 --- a/sdk/tools/mkhive/registry.c +++ b/sdk/tools/mkhive/registry.c @@ -370,7 +370,7 @@ LIST_ENTRY CmiHiveListHead; LIST_ENTRY CmiReparsePointsHead; static LONG -RegpOpenOrCreateKey( +RegpCreateOrOpenKey( IN HKEY hParentKey, IN PCWSTR KeyName, IN BOOL AllowCreation, @@ -390,7 +390,7 @@ RegpOpenOrCreateKey( PCM_KEY_NODE SubKeyCell; HCELL_INDEX BlockOffset; - DPRINT("RegpCreateOpenKey('%S')\n", KeyName); + DPRINT("RegpCreateOrOpenKey('%S')\n", KeyName); if (*KeyName == OBJ_NAME_PATH_SEPARATOR) { @@ -491,7 +491,26 @@ RegCreateKeyW( IN LPCWSTR lpSubKey, OUT PHKEY phkResult) { - return RegpOpenOrCreateKey(hKey, lpSubKey, TRUE, FALSE, phkResult); + return RegpCreateOrOpenKey(hKey, lpSubKey, TRUE, FALSE, phkResult); +} + +LONG WINAPI +RegCreateKeyExW( + IN HKEY hKey, + IN LPCWSTR lpSubKey, + IN DWORD Reserved, + IN LPWSTR lpClass OPTIONAL, + IN DWORD dwOptions, + IN REGSAM samDesired, + IN LPSECURITY_ATTRIBUTES lpSecurityAttributes OPTIONAL, + OUT PHKEY phkResult, + OUT LPDWORD lpdwDisposition OPTIONAL) +{ + return RegpCreateOrOpenKey(hKey, + lpSubKey, + TRUE, + (dwOptions & REG_OPTION_VOLATILE) != 0, + phkResult); } LONG WINAPI @@ -510,26 +529,7 @@ RegOpenKeyW( IN LPCWSTR lpSubKey, OUT PHKEY phkResult) { - return RegpOpenOrCreateKey(hKey, lpSubKey, FALSE, FALSE, phkResult); -} - -LONG WINAPI -RegCreateKeyExW( - IN HKEY hKey, - IN LPCWSTR lpSubKey, - IN DWORD Reserved, - IN LPWSTR lpClass OPTIONAL, - IN DWORD dwOptions, - IN REGSAM samDesired, - IN LPSECURITY_ATTRIBUTES lpSecurityAttributes OPTIONAL, - OUT PHKEY phkResult, - OUT LPDWORD lpdwDisposition OPTIONAL) -{ - return RegpOpenOrCreateKey(hKey, - lpSubKey, - TRUE, - (dwOptions & REG_OPTION_VOLATILE) != 0, - phkResult); + return RegpCreateOrOpenKey(hKey, lpSubKey, FALSE, FALSE, phkResult); } LONG WINAPI @@ -785,9 +785,9 @@ ConnectRegistry( IN PCWSTR Path) { NTSTATUS Status; + LONG rc; PREPARSE_POINT ReparsePoint; PMEMKEY NewKey; - LONG rc; ReparsePoint = (PREPARSE_POINT)malloc(sizeof(*ReparsePoint)); if (!ReparsePoint) @@ -819,7 +819,7 @@ ConnectRegistry( if (!NT_SUCCESS(Status)) DPRINT1("Failed to add security for root key '%S'\n", Path); - /* Create key */ + /* Create the key */ rc = RegCreateKeyExW(RootKey, Path, 0,