Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-23 17:05:46 +00:00
Code Issues Projects Releases Packages Wiki Activity

[WIN32K]

Browse source 
Disable broken code to update a device palette. Should fix testbot crashes.

svn path=/trunk/; revision=70485
This commit is contained in:
Timo Kreuzer 2016-01-03 18:10:31 +00:00
parent 1221a05a4f
commit 4b6f43dcfa
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
reactos/win32ss/gdi/ntgdi/palette.c
View file

@ -786,9 +786,6 @@ IntAnimatePalette(HPALETTE hPal,
{ {
PPALETTE palPtr; PPALETTE palPtr;
UINT pal_entries; UINT pal_entries;
HDC hDC;
PDC dc;
PWND Wnd;
const PALETTEENTRY *pptr = PaletteColors; const PALETTEENTRY *pptr = PaletteColors;
palPtr = PALETTE_ShareLockPalette(hPal); palPtr = PALETTE_ShareLockPalette(hPal);
@ -816,6 +813,16 @@ IntAnimatePalette(HPALETTE hPal,
PALETTE_ShareUnlockPalette(palPtr); PALETTE_ShareUnlockPalette(palPtr);
#if 0
/* FIXME: This is completely broken! We cannot call UserGetDesktopWindow
without first acquiring the USER lock. But the whole process here is
screwed anyway. Instead of messing with the desktop DC, we need to
check, whether the palette is associated with a PDEV and whether that
PDEV supports palette operations. Then we need to call pfnDrvSetPalette.
But since IntGdiRealizePalette() is not even implemented for direct DCs,
we can as well just do nothing, that will at least not ASSERT!
I leave the whole thing here, to scare people away, who want to "fix" it. */
/* Immediately apply the new palette if current window uses it */ /* Immediately apply the new palette if current window uses it */
Wnd = UserGetDesktopWindow(); Wnd = UserGetDesktopWindow();
hDC = UserGetWindowDC(Wnd); hDC = UserGetWindowDC(Wnd);
@ -831,6 +838,7 @@ IntAnimatePalette(HPALETTE hPal,
DC_UnlockDc(dc); DC_UnlockDc(dc);
} }
UserReleaseDC(Wnd,hDC, FALSE); UserReleaseDC(Wnd,hDC, FALSE);
#endif // 0
} }
return ret; return ret;
} }