Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-06-27 16:31:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[MSACM32]

Browse source 
Check allocation success.
Prevent buffer double free.
Already sent & committed upstream: 1ac7096728

svn path=/trunk/; revision=54610
This commit is contained in:
Pierre Schweitzer 2011-12-07 22:16:00 +00:00
parent 7da8d18879
commit 4a177f6424
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
reactos/dll/win32/msacm32/internal.c
View file

@ -1007,6 +1007,9 @@ PWINE_ACMLOCALDRIVERINST MSACM_OpenLocalDriver(PWINE_ACMLOCALDRIVER paldrv, LPAR
PWINE_ACMLOCALDRIVERINST pDrvInst;
pDrvInst = HeapAlloc(MSACM_hHeap, 0, sizeof(WINE_ACMLOCALDRIVERINST));
if (!pDrvInst)
return NULL;
pDrvInst->pLocalDriver = paldrv;
pDrvInst->dwDriverID = 0;
pDrvInst->pNextACMInst = NULL;
@ -1028,9 +1031,14 @@ PWINE_ACMLOCALDRIVERINST MSACM_OpenLocalDriver(PWINE_ACMLOCALDRIVER paldrv, LPAR
ret = MSACM_OpenLocalDriver(paldrv, lParam2);
if (!ret)
{
MSACM_CloseLocalDriver(pDrvInst);
ERR("load1 failed\n");
goto exit;
/* If MSACM_CloseLocalDriver returns TRUE,
* then pDrvInst has been freed
*/
if (!MSACM_CloseLocalDriver(pDrvInst))
goto exit;
return NULL;
}
pDrvInst->bSession = TRUE;
return ret;