From 493bb8de46ce33720c9319efa555ddb441d14519 Mon Sep 17 00:00:00 2001 From: Joachim Henze <33393466+JoachimHenze@users.noreply.github.com> Date: Thu, 31 Mar 2022 21:18:26 +0200 Subject: [PATCH] [CMAKE] msvc.cmake: Remove redundant '/Gy' (#4424) * [CMAKE] msvc.cmake: Remove redundant '/Gy' Function-level-Linking '/Gy' is already enabled unconditionally at line 26. So no need to enable it here another time. Makes the differences between the multiple OPTIMIZE-levels more obvious. * [CMAKE] msvc.cmake: Fix typo in comment --- sdk/cmake/msvc.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk/cmake/msvc.cmake b/sdk/cmake/msvc.cmake index 77de6955619..9f6d4544003 100644 --- a/sdk/cmake/msvc.cmake +++ b/sdk/cmake/msvc.cmake @@ -14,7 +14,7 @@ elseif(OPTIMIZE STREQUAL "3") elseif(OPTIMIZE STREQUAL "4") add_compile_options(/Ob0 /Od) elseif(OPTIMIZE STREQUAL "5") - add_compile_options(/Gy /Ob2 /Os /Ox /GS-) + add_compile_options(/Ob2 /Os /Ox /GS-) endif() # Always use string pooling: this helps reducing the binaries size since a lot @@ -55,7 +55,7 @@ if(ARCH STREQUAL "i386") endif() endif() -# CLang default to -fno-common from version 11 onward. We are not rady for this now +# CLang default to -fno-common from version 11 onward. We are not ready for this now if (USE_CLANG_CL) add_compile_options(-fcommon) endif()