Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-04-26 08:30:21 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NTOS:KE] Fix calculation of timer expiration

Browse source 
Both due-times and interrupt time are unsigned, but were treated as signed in KiInsertTimerTable, which led to very long (e.g. INFINITE) waits being interpreted as having a negative due-time and being completed instantly.
Mostly fixes kernel32_apitest QueueUserAPC
This commit is contained in:
Timo Kreuzer 2024-04-02 21:49:52 +03:00
parent 34576c7015
commit 43b181309e
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ntoskrnl/ke/timerobj.c
View file

@ -63,8 +63,8 @@ FASTCALL
KiInsertTimerTable(IN PKTIMER Timer,
IN ULONG Hand)
{
LARGE_INTEGER InterruptTime;
LONGLONG DueTime = Timer->DueTime.QuadPart;
ULONGLONG InterruptTime;
ULONGLONG DueTime = Timer->DueTime.QuadPart;
BOOLEAN Expired = FALSE;
PLIST_ENTRY ListHead, NextEntry;
PKTIMER CurrentTimer;
@ -101,8 +101,8 @@ KiInsertTimerTable(IN PKTIMER Timer,
KiTimerTableListHead[Hand].Time.QuadPart = DueTime;
/* Make sure it hasn't expired already */
InterruptTime.QuadPart = KeQueryInterruptTime();
if (DueTime <= InterruptTime.QuadPart) Expired = TRUE;
InterruptTime = KeQueryInterruptTime();
if (DueTime <= InterruptTime) Expired = TRUE;
}
/* Return expired state */