From 40a3a52a7b38dbd2a5f5ec86ad73691d89efa6e4 Mon Sep 17 00:00:00 2001
From: Alex Ionescu <aionescu@gmail.com>
Date: Thu, 20 Jul 2006 16:30:07 +0000
Subject: [PATCH] - Add some final missing annotations to kill.c [AUDIT]  -
 Most of the functions are documented at length in Windows Internals II and at
 a more high-level fashion in Windows Internals 4 and were based on that
 information. Undocumented routines were based of the operations done in the
 documented ones (for example, freeing buffers that we know were allocated,
 etc).

svn path=/trunk/; revision=23195
---
 reactos/ntoskrnl/KrnlFun.c |  1 -
 reactos/ntoskrnl/ps/kill.c | 32 ++++++++++++++++----------------
 2 files changed, 16 insertions(+), 17 deletions(-)

diff --git a/reactos/ntoskrnl/KrnlFun.c b/reactos/ntoskrnl/KrnlFun.c
index adbe4ad9bd0..da04663d625 100644
--- a/reactos/ntoskrnl/KrnlFun.c
+++ b/reactos/ntoskrnl/KrnlFun.c
@@ -28,7 +28,6 @@
 //  - Use Process/Thread Rundown.
 //  - Use Process Pushlock Locks.
 //  - Use Safe Referencing where needed.
-//  - Use Guarded Mutex instead of Fast Mutex for Active Process Locks.
 //  - Use Security Locks in security.c
 //  - Figure out why processes don't die.
 //  - Generate process cookie for user-more thread.
diff --git a/reactos/ntoskrnl/ps/kill.c b/reactos/ntoskrnl/ps/kill.c
index ab0366e3173..e9559c2d9da 100644
--- a/reactos/ntoskrnl/ps/kill.c
+++ b/reactos/ntoskrnl/ps/kill.c
@@ -90,7 +90,7 @@ PspExitApcRundown(IN PKAPC Apc)
 
 VOID
 NTAPI
-PspReapRoutine(PVOID Context)
+PspReapRoutine(IN PVOID Context)
 {
     PLIST_ENTRY *ListAddr;
     PLIST_ENTRY NextEntry;
@@ -130,7 +130,7 @@ PspReapRoutine(PVOID Context)
 
 VOID
 NTAPI
-PspDeleteProcess(PVOID ObjectBody)
+PspDeleteProcess(IN PVOID ObjectBody)
 {
     PEPROCESS Process = (PEPROCESS)ObjectBody;
     KAPC_STATE ApcState;
@@ -260,7 +260,7 @@ PspDeleteProcess(PVOID ObjectBody)
 
 VOID
 NTAPI
-PspDeleteThread(PVOID ObjectBody)
+PspDeleteThread(IN PVOID ObjectBody)
 {
     PETHREAD Thread = (PETHREAD)ObjectBody;
     PEPROCESS Process = Thread->ThreadsProcess;
@@ -315,7 +315,7 @@ PspDeleteThread(PVOID ObjectBody)
  */
 VOID
 NTAPI
-PspExitThread(NTSTATUS ExitStatus)
+PspExitThread(IN NTSTATUS ExitStatus)
 {
     CLIENT_DIED_MSG TerminationMsg;
     NTSTATUS Status;
@@ -726,11 +726,11 @@ TryAgain2:
 
 VOID
 NTAPI
-PsExitSpecialApc(PKAPC Apc,
-                 PKNORMAL_ROUTINE* NormalRoutine,
-                 PVOID* NormalContext,
-                 PVOID* SystemArgument1,
-                 PVOID* SystemArguemnt2)
+PsExitSpecialApc(IN PKAPC Apc,
+                 IN OUT PKNORMAL_ROUTINE* NormalRoutine,
+                 IN OUT PVOID* NormalContext,
+                 IN OUT PVOID* SystemArgument1,
+                 IN OUT PVOID* SystemArguemnt2)
 {
     NTSTATUS Status;
     PAGED_CODE();
@@ -749,9 +749,9 @@ PsExitSpecialApc(PKAPC Apc,
 
 VOID
 NTAPI
-PspExitNormalApc(PVOID NormalContext,
-                 PVOID SystemArgument1,
-                 PVOID SystemArgument2)
+PspExitNormalApc(IN PVOID NormalContext,
+                 IN PVOID SystemArgument1,
+                 IN PVOID SystemArgument2)
 {
     PKAPC Apc = (PKAPC)SystemArgument1;
     PETHREAD Thread = PsGetCurrentThread();
@@ -789,9 +789,9 @@ PspExitNormalApc(PVOID NormalContext,
  */
 NTSTATUS
 NTAPI
-PspTerminateThreadByPointer(PETHREAD Thread,
-                            NTSTATUS ExitStatus,
-                            BOOLEAN bSelf)
+PspTerminateThreadByPointer(IN PETHREAD Thread,
+                            IN NTSTATUS ExitStatus,
+                            IN BOOLEAN bSelf)
 {
     PKAPC Apc;
     NTSTATUS Status = STATUS_SUCCESS;
@@ -932,7 +932,7 @@ PspExitProcess(IN BOOLEAN LastThread,
  */
 NTSTATUS
 NTAPI
-PsTerminateSystemThread(NTSTATUS ExitStatus)
+PsTerminateSystemThread(IN NTSTATUS ExitStatus)
 {
     PETHREAD Thread = PsGetCurrentThread();