Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-03 17:45:41 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add SEH...thanks to Hardon for noticing the bugs

Browse source 
svn path=/trunk/; revision=14382
This commit is contained in:
Alex Ionescu 2005-03-30 00:32:38 +00:00
parent c1442ae332
commit 4069692f64
1 changed files with 70 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

74
reactos/ntoskrnl/ps/suspend.c
View file

@ -37,17 +37,36 @@ NtResumeThread(IN HANDLE ThreadHandle,
{ {
PETHREAD Thread; PETHREAD Thread;
NTSTATUS Status; NTSTATUS Status;
ULONG Prev;
KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
PAGED_CODE(); PAGED_CODE();
DPRINT("NtResumeThead(ThreadHandle %lx SuspendCount %p)\n", DPRINT("NtResumeThead(ThreadHandle %lx SuspendCount %p)\n",
ThreadHandle, SuspendCount); ThreadHandle, SuspendCount);
/* Check buffer validity */
if(SuspendCount && PreviousMode == UserMode) {
_SEH_TRY {
ProbeForWrite(SuspendCount,
sizeof(ULONG),
sizeof(ULONG));
} _SEH_HANDLE {
Status = _SEH_GetExceptionCode();
} _SEH_END;
if(!NT_SUCCESS(Status)) return Status;
}
/* Get the Thread Object */ /* Get the Thread Object */
Status = ObReferenceObjectByHandle(ThreadHandle, Status = ObReferenceObjectByHandle(ThreadHandle,
THREAD_SUSPEND_RESUME, THREAD_SUSPEND_RESUME,
PsThreadType, PsThreadType,
KeGetPreviousMode(), PreviousMode,
(PVOID*)&Thread, (PVOID*)&Thread,
NULL); NULL);
if (!NT_SUCCESS(Status)) { if (!NT_SUCCESS(Status)) {
@ -56,7 +75,21 @@ NtResumeThread(IN HANDLE ThreadHandle,
} }
/* Call the Kernel Function */ /* Call the Kernel Function */
*SuspendCount = KeResumeThread(&Thread->Tcb); Prev = KeResumeThread(&Thread->Tcb);
/* Return it */
if(SuspendCount) {
_SEH_TRY {
*SuspendCount = Prev;
} _SEH_HANDLE {
Status = _SEH_GetExceptionCode();
} _SEH_END;
}
/* Dereference and Return */ /* Dereference and Return */
ObDereferenceObject ((PVOID)Thread); ObDereferenceObject ((PVOID)Thread);
@ -83,14 +116,33 @@ NtSuspendThread(IN HANDLE ThreadHandle,
{ {
PETHREAD Thread; PETHREAD Thread;
NTSTATUS Status; NTSTATUS Status;
ULONG Prev;
KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
PAGED_CODE(); PAGED_CODE();
/* Check buffer validity */
if(PreviousSuspendCount && PreviousMode == UserMode) {
_SEH_TRY {
ProbeForWrite(PreviousSuspendCount,
sizeof(ULONG),
sizeof(ULONG));
} _SEH_HANDLE {
Status = _SEH_GetExceptionCode();
} _SEH_END;
if(!NT_SUCCESS(Status)) return Status;
}
/* Get the Thread Object */ /* Get the Thread Object */
Status = ObReferenceObjectByHandle(ThreadHandle, Status = ObReferenceObjectByHandle(ThreadHandle,
THREAD_SUSPEND_RESUME, THREAD_SUSPEND_RESUME,
PsThreadType, PsThreadType,
KeGetPreviousMode(), PreviousMode,
(PVOID*)&Thread, (PVOID*)&Thread,
NULL); NULL);
if (!NT_SUCCESS(Status)) { if (!NT_SUCCESS(Status)) {
@ -99,7 +151,21 @@ NtSuspendThread(IN HANDLE ThreadHandle,
} }
/* Call the Kernel Function */ /* Call the Kernel Function */
*PreviousSuspendCount = KeSuspendThread(&Thread->Tcb); Prev = KeSuspendThread(&Thread->Tcb);
/* Return it */
if(PreviousSuspendCount) {
_SEH_TRY {
*PreviousSuspendCount = Prev;
} _SEH_HANDLE {
Status = _SEH_GetExceptionCode();
} _SEH_END;
}
/* Dereference and Return */ /* Dereference and Return */
ObDereferenceObject((PVOID)Thread); ObDereferenceObject((PVOID)Thread);