Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-09-28 05:26:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

[NTOSKRNL] Use interlocked operations when dealing with map count.

Browse source 
CORE-14349
This commit is contained in:
Pierre Schweitzer 2018-04-08 18:58:15 +02:00
parent 1b672981e2
commit 40017a54f9
1 changed files with 7 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
ntoskrnl/cc/view.c
View file

@ -344,7 +344,7 @@ retry:
CcRosVacbIncRefCount(current); CcRosVacbIncRefCount(current);
/* Check if it's mapped and not dirty */ /* Check if it's mapped and not dirty */
if (current->MappedCount > 0 && !current->Dirty) if (InterlockedCompareExchange((PLONG)&current->MappedCount, 0, 0) > 0 && !current->Dirty)
{ {
/* We have to break these locks because Cc sucks */ /* We have to break these locks because Cc sucks */
KeReleaseSpinLock(&current->SharedCacheMap->CacheMapLock, oldIrql); KeReleaseSpinLock(&current->SharedCacheMap->CacheMapLock, oldIrql);
@ -448,14 +448,13 @@ CcRosReleaseVacb (
if (Mapped) if (Mapped)
{ {
Vacb->MappedCount++; if (InterlockedIncrement((PLONG)&Vacb->MappedCount) == 1)
} {
Refs = CcRosVacbDecRefCount(Vacb); CcRosVacbIncRefCount(Vacb);
if (Mapped && (Vacb->MappedCount == 1)) }
{
CcRosVacbIncRefCount(Vacb);
} }
Refs = CcRosVacbDecRefCount(Vacb);
ASSERT(Refs > 0); ASSERT(Refs > 0);
CcRosReleaseVacbLock(Vacb); CcRosReleaseVacbLock(Vacb);
@ -630,9 +629,7 @@ CcRosUnmapVacb (
} }
ASSERT(Vacb->MappedCount != 0); ASSERT(Vacb->MappedCount != 0);
Vacb->MappedCount--; if (InterlockedDecrement((PLONG)&Vacb->MappedCount) == 0)
if (Vacb->MappedCount == 0)
{ {
CcRosVacbDecRefCount(Vacb); CcRosVacbDecRefCount(Vacb);
} }