[WIN32K]

- Rewrite NtGdiStretchDIBitsInternal : clearer, faster, stronger (+1 wine test)

svn path=/branches/reactos-yarotows/; revision=48465

subsystems/win32/win32k/objects/dibobj.c

@@ -290,7 +290,7 @@ IntSetDIBits(
 
 	if(!(psurfSrc && psurfDst))
 	{
-		DPRINT1("Error, could not lock surfaces.\n");
+		DPRINT1("Error, could not lock surfaces\n");
 		goto cleanup;
 	}
 
@@ -1021,95 +1021,104 @@ NtGdiStretchDIBitsInternal(
     UINT cjMaxBits,
     HANDLE hcmXform)
 {
-    HBITMAP hBitmap, hOldBitmap = NULL;
+    PDC pdc;
-    HDC hdcMem = NULL;
+    INT ret = 0;
+    LONG height;
+    LONG width;
+    WORD planes, bpp;
+    DWORD compr, size;
+    HBITMAP hBitmap;
+    BOOL fastpath = FALSE;
     NTSTATUS Status = STATUS_SUCCESS;
-	PVOID pvDIBits;
+
-	INT Ret = 0;
 
     if (!Bits || !BitsInfo)
+        return 0;
+
+    if (!(pdc = DC_LockDc(hDC))) return 0;
+
+
+    _SEH2_TRY
     {
-        SetLastWin32Error(ERROR_INVALID_PARAMETER);
+        ProbeForRead(BitsInfo, cjMaxInfo, 1);
+        ProbeForRead(Bits, cjMaxBits, 1);
+        if (DIB_GetBitmapInfo( &BitsInfo->bmiHeader, &width, &height, &planes, &bpp, &compr, &size ) == -1)
+        {
+            DPRINT1("Invalid bitmap\n");
+            Status = STATUS_INVALID_PARAMETER;
+        }
+    }
+    _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
+    {
+        Status = _SEH2_GetExceptionCode();
+    }
+    _SEH2_END
+
+    if(!NT_SUCCESS(Status))
+    {
+        DPRINT1("Error, failed to read the DIB bits\n");
+        goto cleanup;
+    }
+
+    if (width < 0)
+    {
+        DPRINT1("Bitmap has a negative width\n");
         return 0;
     }
 
-    /* Create a DIB Section, data will be probed there */
+    hBitmap = NtGdiGetDCObject(hDC, OBJ_BITMAP);
-	hBitmap = NtGdiCreateDIBSection(hDC,
-								  NULL,
-								  0,
-								  BitsInfo,
-								  Usage,
-								  0,
-								  0,
-								  0,
-								  &pvDIBits);
 
-	if(!hBitmap)
+    if (XDest == 0 && YDest == 0 && XSrc == 0 && XSrc == 0 &&
-	{
+        DestWidth == SrcWidth && DestHeight == SrcHeight &&
-		DPRINT1("Failed to create a DIB.\n");
+        compr == BI_RGB &&
-		return 0;
+        ROP == SRCCOPY)
-	}
+    {
+        BITMAP bmp;
+        if (IntGdiGetObject(hBitmap, sizeof(bmp), &bmp) == sizeof(bmp))
+        {
+            if (bmp.bmBitsPixel == bpp &&
+                bmp.bmWidth == SrcWidth &&
+                bmp.bmHeight == SrcHeight &&
+                bmp.bmPlanes == planes)
+                fastpath = TRUE;
+        }
+    }
 
-	/* Set bits */
+    if (fastpath)
-	_SEH2_TRY
+    {
-	{
+        /* fast path */
-		ProbeForRead(Bits, cjMaxBits, 1);
+        DPRINT1("using fast path\n");
-		RtlCopyMemory(pvDIBits, Bits, DIB_GetDIBImageBytes(BitsInfo->bmiHeader.biWidth,
+        ret = IntSetDIBits( pdc, hBitmap, 0, height, Bits, BitsInfo, Usage);
-														   BitsInfo->bmiHeader.biHeight,
+    }
-														   BitsInfo->bmiHeader.biBitCount));
+    else
-	}
+    {
-	_SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
+        /* slow path - need to use StretchBlt */
-	{
+        HBITMAP hOldBitmap;
-		Status = _SEH2_GetExceptionCode();
+        HPALETTE hpal = NULL;
-	}
+        HDC hdcMem;
-	_SEH2_END
+        PVOID pvBits;
 
-	if(!NT_SUCCESS(Status))
+        hdcMem = NtGdiCreateCompatibleDC( hDC );
-	{
+        hBitmap = DIB_CreateDIBSection(pdc, BitsInfo, Usage, &pvBits, NULL, 0, 0);
-		DPRINT1("Error : Could not read DIB bits\n");
+        RtlCopyMemory(pvBits, Bits, cjMaxBits);
-		SetLastNtError(Status);
+        hOldBitmap = NtGdiSelectBitmap( hdcMem, hBitmap );
-		goto cleanup;
-	}
-
-	hdcMem = NtGdiCreateCompatibleDC(0);
-	if(!hdcMem)
-	{
-		DPRINT1("Failed to create a memory DC!");
-		goto cleanup;
-	}
-
-	hOldBitmap = NtGdiSelectBitmap(hdcMem, hBitmap);
-	if(!hOldBitmap)
-	{
-		DPRINT1("Could not select the DIB into the memory DC\n");
-		goto cleanup;
-	}
-
-	/* Do we want to stretch ? */
-	if((SrcWidth == DestWidth) && (SrcHeight == DestHeight))
-	{
-		Ret = NtGdiBitBlt(hDC, XDest, YDest, XDest + DestWidth, YDest + DestHeight, 
-						  hdcMem, XSrc, YSrc, ROP, 0, 0);
-	}
-	else
-	{
-		Ret = NtGdiStretchBlt(hDC, XDest, YDest, XDest + DestWidth, YDest + DestHeight,
-							hdcMem, XSrc, YSrc, XSrc + SrcWidth, YSrc + SrcHeight,
-							ROP, 0);
-	}
-
-	if(Ret)
-		Ret = SrcHeight ;
 
+        /* Origin for DIBitmap may be bottom left (positive biHeight) or top
+           left (negative biHeight) */
+        ret = NtGdiStretchBlt( hDC, XDest, YDest, DestWidth, DestHeight,
+                             hdcMem, XSrc, abs(height) - SrcHeight - YSrc,
+                             SrcWidth, SrcHeight, ROP, 0 );
+        if(hpal)
+            GdiSelectPalette(hdcMem, hpal, FALSE);
+        if(ret)
+            ret = SrcHeight;
+        NtGdiSelectBitmap( hdcMem, hOldBitmap );
+        NtGdiDeleteObjectApp( hdcMem );
+        GreDeleteObject( hBitmap );
+    }
 cleanup:
-	if(hdcMem)
+    DC_UnlockDc(pdc);
-	{
+    return ret;
-		if(hOldBitmap) NtGdiSelectBitmap(hdcMem, hOldBitmap);
-		NtGdiDeleteObjectApp(hdcMem);
-	}
-	GreDeleteObject(hBitmap);
-
-    return Ret;
 }
 
 
@@ -1575,7 +1584,7 @@ DIB_GetBitmapInfo( const BITMAPINFOHEADER *header, LONG *width,
         *height = core->bcHeight;
         *planes = core->bcPlanes;
         *bpp    = core->bcBitCount;
-        *compr  = 0;
+        *compr  = BI_RGB;
         *size   = 0;
         return 0;
     }