Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-09-12 13:54:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix two buffer overflows

Browse source 
svn path=/trunk/; revision=18490
This commit is contained in:
Gunnar Dalsnes 2005-10-16 01:27:32 +00:00
parent 21b0bdd718
commit 3e68f60244
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
reactos/subsys/csrss/init.c
View file

@ -401,16 +401,21 @@ EnvpToUnicodeString (char ** envp, PUNICODE_STRING UnicodeEnv)
AnsiEnv.Buffer = RtlAllocateHeap (RtlGetProcessHeap(), 0, CharCount);
if (NULL != AnsiEnv.Buffer)
{
PCHAR WritePos = AnsiEnv.Buffer;
for (Index=0; NULL != envp[Index]; Index++)
{
strcat (WritePos, envp[Index]);
strcpy (WritePos, envp[Index]);
WritePos += strlen (envp[Index]) + 1;
}
AnsiEnv.Buffer [CharCount] = '\0';
/* FIXME: the last (double) nullterm should perhaps not be included in Length
* but only in MaximumLength. -Gunnar */
AnsiEnv.Buffer [CharCount-1] = '\0';
AnsiEnv.Length = CharCount;
AnsiEnv.MaximumLength = CharCount;
RtlAnsiStringToUnicodeString (UnicodeEnv, & AnsiEnv, TRUE);
RtlFreeHeap (RtlGetProcessHeap(), 0, AnsiEnv.Buffer);
}