Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-05-27 13:08:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

[WINESYNC] msi: Properly declare variables in msi/tests/utils.h as extern.

Browse source 
Omitting the extern storage qualifier when declaring a global variable in
a header file is mistake. If that header is included by several files it
results in multiple definitions of the same variable (unless -fcommon is
specified or assumed, the latter being the case for GCC 9.x and earlier).

This fixes building with GCC 10.

Signed-off-by: Gerald Pfeifer <gerald@pfeifer.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id ea032bb7f8daddfe308f86f52c54db5f657b658a by Gerald Pfeifer <gerald@pfeifer.com>
This commit is contained in:
winesync 2022-03-13 19:08:13 +01:00 committed by Mark Jansen
parent 5741562d55
commit 3d671fafe3
No known key found for this signature in database
GPG key ID: B39240EE84BEAE8B
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
modules/rostests/winetests/msi/utils.h
View file

@ -16,12 +16,12 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
*/ */
char PROG_FILES_DIR[MAX_PATH]; extern char PROG_FILES_DIR[MAX_PATH];
char PROG_FILES_DIR_NATIVE[MAX_PATH]; extern char PROG_FILES_DIR_NATIVE[MAX_PATH];
char COMMON_FILES_DIR[MAX_PATH]; extern char COMMON_FILES_DIR[MAX_PATH];
char APP_DATA_DIR[MAX_PATH]; extern char APP_DATA_DIR[MAX_PATH];
char WINDOWS_DIR[MAX_PATH]; extern char WINDOWS_DIR[MAX_PATH];
char CURR_DIR[MAX_PATH]; extern char CURR_DIR[MAX_PATH];
BOOL get_system_dirs(void); BOOL get_system_dirs(void);
BOOL get_user_dirs(void); BOOL get_user_dirs(void);