Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-07-10 14:45:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

[PCI]

Browse source 
* Add some function annotations.
* Fix several debug print specifiers.
* Properly mark some unreferenced parameters as such.

svn path=/trunk/; revision=58981
This commit is contained in:
Amine Khaldi 2013-05-09 21:24:16 +00:00
parent bd9b579007
commit 39649f0dd6
3 changed files with 28 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
reactos/drivers/bus/pci/fdo.c
View file

@ -456,6 +456,7 @@ FdoSetPower(
{ {
NTSTATUS Status; NTSTATUS Status;
UNREFERENCED_PARAMETER(DeviceObject);
UNREFERENCED_PARAMETER(Irp); UNREFERENCED_PARAMETER(Irp);
DPRINT("Called\n"); DPRINT("Called\n");

8
reactos/drivers/bus/pci/pci.c
View file

@ -53,7 +53,7 @@ PciDispatchDeviceControl(
NTSTATUS Status; NTSTATUS Status;
UNREFERENCED_PARAMETER(DeviceObject); UNREFERENCED_PARAMETER(DeviceObject);
DPRINT("Called. IRP is at (0x%X)\n", Irp); DPRINT("Called. IRP is at (0x%p)\n", Irp);
Irp->IoStatus.Information = 0; Irp->IoStatus.Information = 0;
@ -68,7 +68,7 @@ PciDispatchDeviceControl(
if (Status != STATUS_PENDING) { if (Status != STATUS_PENDING) {
Irp->IoStatus.Status = Status; Irp->IoStatus.Status = Status;
DPRINT("Completing IRP at 0x%X\n", Irp); DPRINT("Completing IRP at 0x%p\n", Irp);
IoCompleteRequest(Irp, IO_NO_INCREMENT); IoCompleteRequest(Irp, IO_NO_INCREMENT);
} }
@ -98,7 +98,7 @@ PciPnpControl(
DeviceExtension = (PCOMMON_DEVICE_EXTENSION)DeviceObject->DeviceExtension; DeviceExtension = (PCOMMON_DEVICE_EXTENSION)DeviceObject->DeviceExtension;
DPRINT("IsFDO %d\n", DeviceExtension->IsFDO); DPRINT("IsFDO %u\n", DeviceExtension->IsFDO);
if (DeviceExtension->IsFDO) { if (DeviceExtension->IsFDO) {
Status = FdoPnpControl(DeviceObject, Irp); Status = FdoPnpControl(DeviceObject, Irp);
@ -180,6 +180,7 @@ PciAddDevice(
return STATUS_SUCCESS; return STATUS_SUCCESS;
} }
DRIVER_UNLOAD PciUnload;
VOID VOID
NTAPI NTAPI
@ -187,6 +188,7 @@ PciUnload(
IN PDRIVER_OBJECT DriverObject) IN PDRIVER_OBJECT DriverObject)
{ {
/* The driver object extension is destroyed by the I/O manager */ /* The driver object extension is destroyed by the I/O manager */
UNREFERENCED_PARAMETER(DriverObject);
} }
NTSTATUS NTSTATUS

29
reactos/drivers/bus/pci/pdo.c
View file

@ -398,7 +398,7 @@ PdoQueryResourceRequirements(
} }
else else
{ {
DPRINT1("Unsupported header type %u\n", PCI_CONFIGURATION_TYPE(&PciConfig)); DPRINT1("Unsupported header type %d\n", PCI_CONFIGURATION_TYPE(&PciConfig));
} }
if (ResCount == 0) if (ResCount == 0)
@ -708,7 +708,7 @@ PdoQueryResources(
} }
else else
{ {
DPRINT1("Unsupported header type %u\n", PCI_CONFIGURATION_TYPE(&PciConfig)); DPRINT1("Unsupported header type %d\n", PCI_CONFIGURATION_TYPE(&PciConfig));
} }
if (ResCount == 0) if (ResCount == 0)
@ -896,8 +896,11 @@ InterfaceDereference(
InterlockedDecrement(&DeviceExtension->References); InterlockedDecrement(&DeviceExtension->References);
} }
static TRANSLATE_BUS_ADDRESS InterfaceBusTranslateBusAddress;
static BOOLEAN NTAPI static
BOOLEAN
NTAPI
InterfaceBusTranslateBusAddress( InterfaceBusTranslateBusAddress(
IN PVOID Context, IN PVOID Context,
IN PHYSICAL_ADDRESS BusAddress, IN PHYSICAL_ADDRESS BusAddress,
@ -917,8 +920,11 @@ InterfaceBusTranslateBusAddress(
BusAddress, AddressSpace, TranslatedAddress); BusAddress, AddressSpace, TranslatedAddress);
} }
static GET_DMA_ADAPTER InterfaceBusGetDmaAdapter;
static PDMA_ADAPTER NTAPI static
PDMA_ADAPTER
NTAPI
InterfaceBusGetDmaAdapter( InterfaceBusGetDmaAdapter(
IN PVOID Context, IN PVOID Context,
IN PDEVICE_DESCRIPTION DeviceDescription, IN PDEVICE_DESCRIPTION DeviceDescription,
@ -929,8 +935,11 @@ InterfaceBusGetDmaAdapter(
return (PDMA_ADAPTER)HalGetAdapter(DeviceDescription, NumberOfMapRegisters); return (PDMA_ADAPTER)HalGetAdapter(DeviceDescription, NumberOfMapRegisters);
} }
static GET_SET_DEVICE_DATA InterfaceBusSetBusData;
static ULONG NTAPI static
ULONG
NTAPI
InterfaceBusSetBusData( InterfaceBusSetBusData(
IN PVOID Context, IN PVOID Context,
IN ULONG DataType, IN ULONG DataType,
@ -962,8 +971,11 @@ InterfaceBusSetBusData(
return Size; return Size;
} }
static GET_SET_DEVICE_DATA InterfaceBusGetBusData;
static ULONG NTAPI static
ULONG
NTAPI
InterfaceBusGetBusData( InterfaceBusGetBusData(
IN PVOID Context, IN PVOID Context,
IN ULONG DataType, IN ULONG DataType,
@ -1229,6 +1241,8 @@ PdoStartDevice(
UCHAR Irq; UCHAR Irq;
USHORT Command; USHORT Command;
UNREFERENCED_PARAMETER(Irp);
if (!RawResList) if (!RawResList)
return STATUS_SUCCESS; return STATUS_SUCCESS;
@ -1244,7 +1258,7 @@ PdoStartDevice(
if (RawPartialDesc->Type == CmResourceTypeInterrupt) if (RawPartialDesc->Type == CmResourceTypeInterrupt)
{ {
DPRINT1("Assigning IRQ %d to PCI device 0x%x on bus 0x%x\n", DPRINT1("Assigning IRQ %u to PCI device 0x%x on bus 0x%x\n",
RawPartialDesc->u.Interrupt.Vector, RawPartialDesc->u.Interrupt.Vector,
DeviceExtension->PciDevice->SlotNumber.u.AsULONG, DeviceExtension->PciDevice->SlotNumber.u.AsULONG,
DeviceExtension->PciDevice->BusNumber); DeviceExtension->PciDevice->BusNumber);
@ -1401,6 +1415,7 @@ PdoSetPower(
{ {
NTSTATUS Status; NTSTATUS Status;
UNREFERENCED_PARAMETER(DeviceObject);
UNREFERENCED_PARAMETER(Irp); UNREFERENCED_PARAMETER(Irp);
DPRINT("Called\n"); DPRINT("Called\n");