[ACPPAGE] Improve the compatibility tab (#332)

- Use the tab title from the corresponding dialog resource caption string.
- Fix some translations, and complete the french one.
- Use DialogBoxParamW and MAKEINTRESOURCEW (with W).

dll/shellext/acppage/CLayerUIPropPage.cpp

@@ -95,10 +95,16 @@ CLayerUIPropPage::CLayerUIPropPage()
 , m_RegistryEnabledLayers(0)
 , m_EnabledLayers(0)
 {
+    CComBSTR title;
+    title.LoadString(g_hModule, IDS_COMPAT_TITLE);
+    m_psp.pszTitle = title.Detach();
+    m_psp.dwFlags |= PSP_USETITLE;
 }
 
 CLayerUIPropPage::~CLayerUIPropPage()
 {
+    CComBSTR title;
+    title.Attach((BSTR)m_psp.pszTitle);
 }
 
 HRESULT CLayerUIPropPage::InitFile(PCWSTR Filename)
@@ -371,7 +377,7 @@ LRESULT CLayerUIPropPage::OnCtrlCommand(WORD wNotifyCode, WORD wID, HWND hWndCtl
 
 LRESULT CLayerUIPropPage::OnEditModes(WORD wNotifyCode, WORD wID, HWND hWndCtl, BOOL &bHandled)
 {
-    if (DialogBoxParam(g_hModule, MAKEINTRESOURCE(IDD_EDITCOMPATIBILITYMODES), m_hWnd, EditModesProc, (LPARAM)this) == IDOK)
+    if (DialogBoxParamW(g_hModule, MAKEINTRESOURCEW(IDD_EDITCOMPATIBILITYMODES), m_hWnd, EditModesProc, (LPARAM)this) == IDOK)
         UpdateControls();
     return 0;
 }
@@ -499,7 +505,7 @@ INT_PTR CALLBACK CLayerUIPropPage::EditModesProc(HWND hWnd, UINT uMsg, WPARAM wP
             if (ComboHasData(hWnd))
             {
                 CComBSTR question, title;
-                title.LoadString(g_hModule, IDS_TABTITLE);
+                title.LoadString(g_hModule, IDS_COMPAT_TITLE);
                 question.LoadString(g_hModule, IDS_YOU_DID_NOT_ADD);
                 int result = ::MessageBoxW(hWnd, question, title, MB_YESNOCANCEL | MB_ICONQUESTION);
                 switch (result)

dll/shellext/acppage/lang/bg-BG.rc

@@ -33,7 +33,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibility"
+    IDS_COMPAT_TITLE "Съвместимост"
     IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
     IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
     IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"

dll/shellext/acppage/lang/cs-CZ.rc

@@ -38,7 +38,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibility"
+    IDS_COMPAT_TITLE "Kompatibilita"
     IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
     IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
     IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"

dll/shellext/acppage/lang/de-DE.rc

@@ -33,7 +33,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Kompatibilität"
+    IDS_COMPAT_TITLE "Kompatibilität"
     IDS_FAILED_NETWORK "Kompatibilitätsmodi können auf diesem Programm nicht angewendet werden, da es sich auf einem Netzlaufwerk befindet."
     IDS_FAILED_PROTECTED "Kompatibilitätsmodi können auf diesem Programm nicht angewendet werden, da es Teil von ReactOS ist."
     IDS_YOU_DID_NOT_ADD "Sie haben den Modus nicht hinzugefügt, möchten Sie ihn jetzt hinzufügen?"

dll/shellext/acppage/lang/en-US.rc

@@ -33,7 +33,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibility"
+    IDS_COMPAT_TITLE "Compatibility"
     IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
     IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
     IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"

dll/shellext/acppage/lang/es-ES.rc

@@ -35,7 +35,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibility"
+    IDS_COMPAT_TITLE "Compatibilidad"
     IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
     IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
     IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"

dll/shellext/acppage/lang/eu-ES.rc

@@ -33,7 +33,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibility"
+    IDS_COMPAT_TITLE "Konpatibilitatea"
     IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
     IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
     IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"

dll/shellext/acppage/lang/fr-FR.rc

@@ -5,16 +5,16 @@ STYLE DS_SHELLFONT | WS_CHILD | WS_DISABLED | WS_CAPTION
 CAPTION "Compatibilité"
 FONT 8, "MS Shell Dlg", 0, 0, 0x0
 BEGIN
-    LTEXT "Si vous avez des difficultés à lancer ce programme sous ReactOS, sélectionner le système d'exploitation que ReactOS montrera à l'application.\nPlease note that this is a work in progress.", -1, 7, 7, 210, 31
+    LTEXT "Si vous avez des difficultés à lancer ce programme sous ReactOS, sélectionnez le système d'exploitation que ReactOS montrera à l'application.\nCette fonctionnalité est en cours de développement.", -1, 7, 7, 210, 31
     GROUPBOX "Mode de compatibilité", IDC_COMPATGROUP, 7, 41, 210, 49
     CHECKBOX "Lancer ce programme en mode de compatibilité pour :", IDC_CHKRUNCOMPATIBILITY, 18, 57, 188, 10, BS_AUTOCHECKBOX | WS_TABSTOP
     COMBOBOX IDC_COMPATIBILITYMODE, 18, 70, 188, 85, CBS_HASSTRINGS | CBS_DROPDOWNLIST | WS_TABSTOP | WS_DISABLED
     GROUPBOX "Réglages de l'écran", -1, 7, 99, 210, 61, BS_GROUPBOX
     CHECKBOX "Lancer en 256 colors", IDC_CHKRUNIN256COLORS, 18, 114, 188, 10, BS_AUTOCHECKBOX | WS_TABSTOP
-    CHECKBOX "Lancer en resolution d'écran 640x480 ", IDC_CHKRUNIN640480RES, 18, 129, 188, 10, BS_AUTOCHECKBOX | WS_TABSTOP
+    CHECKBOX "Lancer en résolution d'écran 640x480 ", IDC_CHKRUNIN640480RES, 18, 129, 188, 10, BS_AUTOCHECKBOX | WS_TABSTOP
     CHECKBOX "Désactiver les thèmes visuels", IDC_CHKDISABLEVISUALTHEMES, 18, 144, 188, 10, BS_AUTOCHECKBOX | WS_TABSTOP
-    PUSHBUTTON "E&diter les Modes de compatibilité", IDC_EDITCOMPATIBILITYMODES, 117, 167, 100, 15
+    PUSHBUTTON "É&diter les Modes de compatibilité", IDC_EDITCOMPATIBILITYMODES, 117, 167, 100, 15
-    CONTROL "Learn more about <A>program compatibility</A>.", IDC_INFOLINK, "SysLink", WS_CHILD | WS_TABSTOP | WS_VISIBLE, 7, 207, 210, 10, WS_EX_NOPARENTNOTIFY
+    CONTROL "En savoir plus sur <A>la compatibilité des programmes</A>.", IDC_INFOLINK, "SysLink", WS_CHILD | WS_TABSTOP | WS_VISIBLE, 7, 207, 210, 10, WS_EX_NOPARENTNOTIFY
 END
 
 IDD_EDITCOMPATIBILITYMODES DIALOGEX 0, 0, 230, 139
@@ -25,7 +25,7 @@ BEGIN
     COMBOBOX IDC_NEWCOMPATIBILITYMODE, 9, 6, 148, 14, CBS_HASSTRINGS | CBS_DROPDOWN | WS_VSCROLL
     LISTBOX IDC_COMPATIBILITYMODE, 9, 25, 148, 86, LBS_NOTIFY | LBS_NOINTEGRALHEIGHT | LBS_WANTKEYBOARDINPUT | WS_BORDER
     PUSHBUTTON "&Ajouter...", IDC_ADD, 162, 6, 60, 14, WS_DISABLED
-    PUSHBUTTON "&Editer...", IDC_EDIT, 162, 24, 60, 14, WS_DISABLED
+    PUSHBUTTON "&Éditer...", IDC_EDIT, 162, 24, 60, 14, WS_DISABLED
     PUSHBUTTON "&Supprimer", IDC_DELETE, 162, 42, 60, 14, WS_DISABLED
     PUSHBUTTON "&OK", IDOK, 95, 116, 60, 14
     PUSHBUTTON "&Annuler", IDCANCEL, 162, 116, 60, 14
@@ -33,8 +33,8 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibility"
+    IDS_COMPAT_TITLE "Compatibilité"
-    IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
+    IDS_FAILED_NETWORK "Les modes de compatibilité ne peuvent pas être appliqués sur ce programme car il se situe sur un lecteur réseau."
-    IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
+    IDS_FAILED_PROTECTED "Les modes de compatibilité ne peuvent pas être appliqués sur ce programme car il fait partie de ReactOS."
-    IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"
+    IDS_YOU_DID_NOT_ADD "Vous n'avez pas ajouté le mode, voulez-vous l'ajouter maintenant ?"
 END

dll/shellext/acppage/lang/he-IL.rc

@@ -35,7 +35,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibility"
+    IDS_COMPAT_TITLE "תאימות"
     IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
     IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
     IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"

dll/shellext/acppage/lang/hu-HU.rc

@@ -35,7 +35,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibility"
+    IDS_COMPAT_TITLE "Kompatibilitás"
     IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
     IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
     IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"

dll/shellext/acppage/lang/id-ID.rc

@@ -33,7 +33,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibility"
+    IDS_COMPAT_TITLE "Kompatibilitas"
     IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
     IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
     IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"

dll/shellext/acppage/lang/it-IT.rc

@@ -35,7 +35,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibility"
+    IDS_COMPAT_TITLE "Compatibilità"
     IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
     IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
     IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"

dll/shellext/acppage/lang/nl-NL.rc

@@ -33,7 +33,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibility"
+    IDS_COMPAT_TITLE "Compatibiliteit"
     IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
     IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
     IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"

dll/shellext/acppage/lang/no-NO.rc

@@ -33,7 +33,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibility"
+    IDS_COMPAT_TITLE "Kompaktibilitet"
     IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
     IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
     IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"

dll/shellext/acppage/lang/pl-PL.rc

@@ -35,7 +35,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Zgodność"
+    IDS_COMPAT_TITLE "Zgodność"
     IDS_FAILED_NETWORK "Nie można ustawić trybu zgodnośći dla tego programu, ponieważ znajduje się na dysku sieciowym."
     IDS_FAILED_PROTECTED "Nie można ustawić trybu zgodnośći dla tego programu, ponieważ jest częścią systemu ReactOS."
     IDS_YOU_DID_NOT_ADD "Nie dodałeś trybu zgodności, czy chcesz to zrobić teraz?"

dll/shellext/acppage/lang/ro-RO.rc

@@ -35,7 +35,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibilitate"
+    IDS_COMPAT_TITLE "Compatibilitate"
     IDS_FAILED_NETWORK "Modurile de compatibilitate nu pot fi instituite pentru acest program deoarece rezidă pe o unitate de stocare în rețea."
     IDS_FAILED_PROTECTED "Modurile de compatibilitate nu pot fi instituite pentru acest program deoarece este parte din ReactOS."
     IDS_YOU_DID_NOT_ADD "Nu ați specificat un mod. Doriți să specificați unul?"

dll/shellext/acppage/lang/ru-RU.rc

@@ -35,7 +35,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Совместимость"
+    IDS_COMPAT_TITLE "Совместимость"
     IDS_FAILED_NETWORK "Режим совместимости не может быть установлен для этой программы, потому что она находится на сетевом диске."
     IDS_FAILED_PROTECTED "Режим совместимости не может быть использован для компонентов ReactOS."
     IDS_YOU_DID_NOT_ADD "Вы не добавили режим, добавить его сейчас?"

dll/shellext/acppage/lang/sk-SK.rc

@@ -40,7 +40,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibility"
+    IDS_COMPAT_TITLE "Kompatibilita"
     IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
     IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
     IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"

dll/shellext/acppage/lang/sq-AL.rc

@@ -37,7 +37,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibility"
+    IDS_COMPAT_TITLE "Pajtueshmëri"
     IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
     IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
     IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"

dll/shellext/acppage/lang/sv-SE.rc

@@ -35,7 +35,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Kompabilitet"
+    IDS_COMPAT_TITLE "Kompatibilitet"
     IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
     IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
     IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"

dll/shellext/acppage/lang/tr-TR.rc

@@ -35,7 +35,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Uyumluluk"
+    IDS_COMPAT_TITLE "Uyumluluk"
     IDS_FAILED_NETWORK "Bir ağ sürücüsü üzerinde olduğundan bu programda uyumluluk kipleri ayarlanamaz."
     IDS_FAILED_PROTECTED "ReactOS'un bir parçası olduğundan bu programda uyumluluk kipleri ayarlanamaz."
     IDS_YOU_DID_NOT_ADD "Bu modu eklememeiştiniz, eklemek ister misiniz?"

dll/shellext/acppage/lang/uk-UA.rc

@@ -41,7 +41,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibility"
+    IDS_COMPAT_TITLE "Сумісність"
     IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
     IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
     IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"

dll/shellext/acppage/lang/zh-CN.rc

@@ -35,7 +35,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "兼容模式"
+    IDS_COMPAT_TITLE "兼容模式"
     IDS_FAILED_NETWORK "无法在上面设置兼容模式，因为这个程序在网络驱动器上。"
     IDS_FAILED_PROTECTED "无法在上面设置兼容模式，因为这个程序是 ReactOS 的一部分。"
     IDS_YOU_DID_NOT_ADD "目前没有此模式，你想要新建一个吗？"

dll/shellext/acppage/lang/zh-TW.rc

@@ -35,7 +35,7 @@ END
 
 STRINGTABLE
 BEGIN
-    IDS_TABTITLE "Compatibility"
+    IDS_COMPAT_TITLE "相容性"
     IDS_FAILED_NETWORK "Compatibility modes cannot be set on this program because it is on a network drive."
     IDS_FAILED_PROTECTED "Compatibility modes cannot be set on this program because it is a part of ReactOS."
     IDS_YOU_DID_NOT_ADD "You did not add the mode, do you want to add it now?"

dll/shellext/acppage/resource.h

@@ -20,7 +20,7 @@
 #define IDS_DESCRIPTION 101
 
 /* strings */
-#define IDS_TABTITLE                    2000
+#define IDS_COMPAT_TITLE                2000
 #define IDS_FAILED_NETWORK              2001
 #define IDS_FAILED_PROTECTED            2002
 #define IDS_YOU_DID_NOT_ADD             2003