Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-28 10:04:49 +00:00
Code Issues Projects Releases Packages Wiki Activity

[WIN32K:NTUSER] Add ASSERT() on "linking window to itself" (#4749)

Browse source 
Addendum to ee0511b (0.4.10-dev-323).
CORE-18132
This commit is contained in:
Serge Gautherie 2023-07-02 13:19:06 +02:00 committed by GitHub
parent 5e4c6ae983
commit 38560761ce
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
win32ss/user/ntuser/window.c
View file

@ -943,7 +943,8 @@ IntLinkWindow(
{ {
if (Wnd == WndInsertAfter) if (Wnd == WndInsertAfter)
{ {
ERR("IntLinkWindow -- Trying to link window 0x%p to itself!!\n", Wnd); ERR("Trying to link window 0x%p to itself\n", Wnd);
ASSERT(WndInsertAfter != Wnd);
return; return;
} }
@ -1046,8 +1047,15 @@ VOID FASTCALL IntLinkHwnd(PWND Wnd, HWND hWndPrev)
} }
if (Wnd == WndInsertAfter) if (Wnd == WndInsertAfter)
ERR("IntLinkHwnd -- Trying to link window 0x%p to itself!!\n", Wnd); {
IntLinkWindow(Wnd, WndInsertAfter); ERR("Trying to link window 0x%p to itself\n", Wnd);
ASSERT(WndInsertAfter != Wnd);
// FIXME: IntUnlinkWindow(Wnd) was already called. Continuing as is seems wrong!
}
else
{
IntLinkWindow(Wnd, WndInsertAfter);
}
/* Fix the WS_EX_TOPMOST flag */ /* Fix the WS_EX_TOPMOST flag */
if (!(WndInsertAfter->ExStyle & WS_EX_TOPMOST)) if (!(WndInsertAfter->ExStyle & WS_EX_TOPMOST))