Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-06 08:03:03 +00:00
Code Issues Projects Releases Packages Wiki Activity

secure access to buffers in NtQueryInformationProcess() and NtSetInformationProcess()

Browse source 
svn path=/trunk/; revision=13143
This commit is contained in:
Thomas Bluemel 2005-01-19 22:47:26 +00:00
parent 9543041c3d
commit 3638fef3ce
1 changed files with 171 additions and 82 deletions
Download patch file Download diff file Expand all files Collapse all files

245
reactos/ntoskrnl/ps/process.c
View file

@ -1147,7 +1147,7 @@ NtQueryInformationProcess(IN HANDLE ProcessHandle,
PreviousMode, PreviousMode,
(PVOID*)&Process, (PVOID*)&Process,
NULL); NULL);
if (Status != STATUS_SUCCESS) if (!NT_SUCCESS(Status))
{ {
return(Status); return(Status);
} }
@ -1161,22 +1161,31 @@ NtQueryInformationProcess(IN HANDLE ProcessHandle,
} }
else else
{ {
PPROCESS_BASIC_INFORMATION ProcessBasicInformationP = PPROCESS_BASIC_INFORMATION ProcessBasicInformationP =
(PPROCESS_BASIC_INFORMATION)ProcessInformation; (PPROCESS_BASIC_INFORMATION)ProcessInformation;
ProcessBasicInformationP->ExitStatus = Process->ExitStatus;
ProcessBasicInformationP->PebBaseAddress = Process->Peb;
ProcessBasicInformationP->AffinityMask = Process->Pcb.Affinity;
ProcessBasicInformationP->UniqueProcessId =
Process->UniqueProcessId;
ProcessBasicInformationP->InheritedFromUniqueProcessId =
(ULONG)Process->InheritedFromUniqueProcessId;
ProcessBasicInformationP->BasePriority =
Process->Pcb.BasePriority;
if (ReturnLength) _SEH_TRY
{ {
*ReturnLength = sizeof(PROCESS_BASIC_INFORMATION); ProcessBasicInformationP->ExitStatus = Process->ExitStatus;
} ProcessBasicInformationP->PebBaseAddress = Process->Peb;
ProcessBasicInformationP->AffinityMask = Process->Pcb.Affinity;
ProcessBasicInformationP->UniqueProcessId =
Process->UniqueProcessId;
ProcessBasicInformationP->InheritedFromUniqueProcessId =
(ULONG)Process->InheritedFromUniqueProcessId;
ProcessBasicInformationP->BasePriority =
Process->Pcb.BasePriority;
if (ReturnLength)
{
*ReturnLength = sizeof(PROCESS_BASIC_INFORMATION);
}
}
_SEH_HANDLE
{
Status = _SEH_GetExceptionCode();
}
_SEH_END;
} }
break; break;
@ -1192,18 +1201,24 @@ NtQueryInformationProcess(IN HANDLE ProcessHandle,
} }
else else
{ {
PKERNEL_USER_TIMES ProcessTimeP = PKERNEL_USER_TIMES ProcessTimeP = (PKERNEL_USER_TIMES)ProcessInformation;
(PKERNEL_USER_TIMES)ProcessInformation; _SEH_TRY
{
ProcessTimeP->CreateTime = Process->CreateTime;
ProcessTimeP->UserTime.QuadPart = Process->Pcb.UserTime * 100000LL;
ProcessTimeP->KernelTime.QuadPart = Process->Pcb.KernelTime * 100000LL;
ProcessTimeP->ExitTime = Process->ExitTime;
ProcessTimeP->CreateTime = Process->CreateTime; if (ReturnLength)
ProcessTimeP->UserTime.QuadPart = Process->Pcb.UserTime * 100000LL; {
ProcessTimeP->KernelTime.QuadPart = Process->Pcb.KernelTime * 100000LL; *ReturnLength = sizeof(KERNEL_USER_TIMES);
ProcessTimeP->ExitTime = Process->ExitTime; }
}
if (ReturnLength) _SEH_HANDLE
{ {
*ReturnLength = sizeof(KERNEL_USER_TIMES); Status = _SEH_GetExceptionCode();
} }
_SEH_END;
} }
break; break;
@ -1221,12 +1236,21 @@ NtQueryInformationProcess(IN HANDLE ProcessHandle,
} }
else else
{ {
PULONG HandleCount = (PULONG)ProcessInformation; ULONG HandleCount = ObpGetHandleCountByHandleTable(&Process->HandleTable);
*HandleCount = ObpGetHandleCountByHandleTable(&Process->HandleTable);
if (ReturnLength) _SEH_TRY
{ {
*ReturnLength = sizeof(ULONG); *(PULONG)ProcessInformation = HandleCount;
if (ReturnLength)
{
*ReturnLength = sizeof(ULONG);
}
} }
_SEH_HANDLE
{
Status = _SEH_GetExceptionCode();
}
_SEH_END;
} }
break; break;
@ -1247,7 +1271,6 @@ NtQueryInformationProcess(IN HANDLE ProcessHandle,
{ {
*ReturnLength = sizeof(PROCESS_SESSION_INFORMATION); *ReturnLength = sizeof(PROCESS_SESSION_INFORMATION);
} }
Status = STATUS_SUCCESS;
} }
_SEH_HANDLE _SEH_HANDLE
{ {
@ -1271,27 +1294,36 @@ NtQueryInformationProcess(IN HANDLE ProcessHandle,
else else
{ {
PVM_COUNTERS pOut = (PVM_COUNTERS)ProcessInformation; PVM_COUNTERS pOut = (PVM_COUNTERS)ProcessInformation;
pOut->PeakVirtualSize = Process->PeakVirtualSize;
/*
* Here we should probably use VirtualSize.LowPart, but due to
* incompatibilities in current headers (no unnamed union),
* I opted for cast.
*/
pOut->VirtualSize = (ULONG)Process->VirtualSize.QuadPart;
pOut->PageFaultCount = Process->Vm.PageFaultCount;
pOut->PeakWorkingSetSize = Process->Vm.PeakWorkingSetSize;
pOut->WorkingSetSize = Process->Vm.WorkingSetSize;
pOut->QuotaPeakPagedPoolUsage = Process->QuotaPeakPoolUsage[0]; // TODO: Verify!
pOut->QuotaPagedPoolUsage = Process->QuotaPoolUsage[0]; // TODO: Verify!
pOut->QuotaPeakNonPagedPoolUsage = Process->QuotaPeakPoolUsage[1]; // TODO: Verify!
pOut->QuotaNonPagedPoolUsage = Process->QuotaPoolUsage[1]; // TODO: Verify!
pOut->PagefileUsage = Process->PagefileUsage;
pOut->PeakPagefileUsage = Process->PeakPagefileUsage;
if (ReturnLength) _SEH_TRY
{ {
*ReturnLength = sizeof(VM_COUNTERS); pOut->PeakVirtualSize = Process->PeakVirtualSize;
} /*
* Here we should probably use VirtualSize.LowPart, but due to
* incompatibilities in current headers (no unnamed union),
* I opted for cast.
*/
pOut->VirtualSize = (ULONG)Process->VirtualSize.QuadPart;
pOut->PageFaultCount = Process->Vm.PageFaultCount;
pOut->PeakWorkingSetSize = Process->Vm.PeakWorkingSetSize;
pOut->WorkingSetSize = Process->Vm.WorkingSetSize;
pOut->QuotaPeakPagedPoolUsage = Process->QuotaPeakPoolUsage[0]; // TODO: Verify!
pOut->QuotaPagedPoolUsage = Process->QuotaPoolUsage[0]; // TODO: Verify!
pOut->QuotaPeakNonPagedPoolUsage = Process->QuotaPeakPoolUsage[1]; // TODO: Verify!
pOut->QuotaNonPagedPoolUsage = Process->QuotaPoolUsage[1]; // TODO: Verify!
pOut->PagefileUsage = Process->PagefileUsage;
pOut->PeakPagefileUsage = Process->PeakPagefileUsage;
if (ReturnLength)
{
*ReturnLength = sizeof(VM_COUNTERS);
}
}
_SEH_HANDLE
{
Status = _SEH_GetExceptionCode();
}
_SEH_END;
} }
break; break;
@ -1310,8 +1342,6 @@ NtQueryInformationProcess(IN HANDLE ProcessHandle,
{ {
*ReturnLength = sizeof(ULONG); *ReturnLength = sizeof(ULONG);
} }
Status = STATUS_SUCCESS;
} }
_SEH_HANDLE _SEH_HANDLE
{ {
@ -1329,12 +1359,21 @@ NtQueryInformationProcess(IN HANDLE ProcessHandle,
else else
{ {
PULONG BoostEnabled = (PULONG)ProcessInformation; PULONG BoostEnabled = (PULONG)ProcessInformation;
*BoostEnabled = Process->Pcb.DisableBoost ? FALSE : TRUE;
if (ReturnLength) _SEH_TRY
{ {
*ReturnLength = sizeof(ULONG); *BoostEnabled = Process->Pcb.DisableBoost ? FALSE : TRUE;
}
if (ReturnLength)
{
*ReturnLength = sizeof(ULONG);
}
}
_SEH_HANDLE
{
Status = _SEH_GetExceptionCode();
}
_SEH_END;
} }
break; break;
@ -1345,11 +1384,23 @@ NtQueryInformationProcess(IN HANDLE ProcessHandle,
} }
else else
{ {
ObQueryDeviceMapInformation(Process, (PPROCESS_DEVICEMAP_INFORMATION)ProcessInformation); PROCESS_DEVICEMAP_INFORMATION DeviceMap;
if (ReturnLength)
ObQueryDeviceMapInformation(Process, &DeviceMap);
_SEH_TRY
{ {
*ReturnLength = sizeof(PROCESS_DEVICEMAP_INFORMATION); *(PPROCESS_DEVICEMAP_INFORMATION)ProcessInformation = DeviceMap;
} if (ReturnLength)
{
*ReturnLength = sizeof(PROCESS_DEVICEMAP_INFORMATION);
}
}
_SEH_HANDLE
{
Status = _SEH_GetExceptionCode();
}
_SEH_END;
} }
break; break;
@ -1361,12 +1412,21 @@ NtQueryInformationProcess(IN HANDLE ProcessHandle,
else else
{ {
PUSHORT Priority = (PUSHORT)ProcessInformation; PUSHORT Priority = (PUSHORT)ProcessInformation;
*Priority = Process->PriorityClass;
if (ReturnLength) _SEH_TRY
{ {
*ReturnLength = sizeof(USHORT); *Priority = Process->PriorityClass;
}
if (ReturnLength)
{
*ReturnLength = sizeof(USHORT);
}
}
_SEH_HANDLE
{
Status = _SEH_GetExceptionCode();
}
_SEH_END;
} }
break; break;
@ -1377,23 +1437,51 @@ NtQueryInformationProcess(IN HANDLE ProcessHandle,
* Propably if we can't find a PEB or ProcessParameters structure for the * Propably if we can't find a PEB or ProcessParameters structure for the
* process! * process!
*/ */
PRTL_USER_PROCESS_PARAMETERS ProcParams; if(Process->Peb != NULL)
ASSERT(Process->Peb);
ASSERT(Process->Peb->ProcessParameters);
ProcParams = Process->Peb->ProcessParameters;
if(ProcessInformationLength < sizeof(UNICODE_STRING) + ProcParams->ImagePathName.Length + sizeof(WCHAR))
{ {
Status = STATUS_INFO_LENGTH_MISMATCH; PRTL_USER_PROCESS_PARAMETERS ProcParams;
/* we need to attach to the process to make sure we're in the right context! */
KeAttachProcess(&Process->Pcb);
ASSERT(Process->Peb->ProcessParameters); /* FIXME - must ProcessParameters be really != NULL? */
ProcParams = Process->Peb->ProcessParameters;
if(ProcessInformationLength < sizeof(UNICODE_STRING) + ProcParams->ImagePathName.Length + sizeof(WCHAR))
{
Status = STATUS_INFO_LENGTH_MISMATCH;
}
else
{
PUNICODE_STRING DstPath = (PUNICODE_STRING)ProcessInformation;
_SEH_TRY
{
DstPath->Length = ProcParams->ImagePathName.Length;
DstPath->MaximumLength = DstPath->Length + sizeof(WCHAR);
DstPath->Buffer = (PWSTR)(DstPath + 1);
RtlCopyMemory(DstPath->Buffer, ProcParams->ImagePathName.Buffer, ProcParams->ImagePathName.Length);
DstPath->Buffer[DstPath->Length / sizeof(WCHAR)] = L'\0';
if (ReturnLength)
{
*ReturnLength = sizeof(UNICODE_STRING) + ProcParams->ImagePathName.Length + sizeof(WCHAR);
}
}
_SEH_HANDLE
{
Status = _SEH_GetExceptionCode();
}
_SEH_END;
}
KeDetachProcess();
} }
else else
{ {
PUNICODE_STRING DstPath = (PUNICODE_STRING)ProcessInformation; /* FIXME - what to do here? */
DstPath->Length = ProcParams->ImagePathName.Length; Status = STATUS_UNSUCCESSFUL;
DstPath->MaximumLength = DstPath->Length + sizeof(WCHAR);
DstPath->Buffer = (PWSTR)(DstPath + 1);
RtlCopyMemory(DstPath->Buffer, ProcParams->ImagePathName.Buffer, ProcParams->ImagePathName.Length);
DstPath->Buffer[DstPath->Length / sizeof(WCHAR)] = L'\0';
} }
break; break;
} }
@ -1415,8 +1503,9 @@ NtQueryInformationProcess(IN HANDLE ProcessHandle,
default: default:
Status = STATUS_INVALID_INFO_CLASS; Status = STATUS_INVALID_INFO_CLASS;
} }
ObDereferenceObject(Process); ObDereferenceObject(Process);
return(Status); return Status;
} }