Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-22 16:36:33 +00:00
Code Issues Projects Releases Packages Wiki Activity

GetDetailsOf does not support column flags (#5755)

Browse source 
GetDetailsOf does not support the column flags used by CompareIDs.
As a side effect, also fixes LPARAM to UINT truncation on 64-bit.
This commit is contained in:
Whindmar Saksit 2023-10-03 10:43:44 +02:00 committed by GitHub
parent 6528ab8fcb
commit 34066e475a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
dll/win32/shell32/shlfolder.cpp
View file

@ -241,8 +241,9 @@ HRESULT SHELL32_CompareDetails(IShellFolder2* isf, LPARAM lParam, LPCITEMIDLIST
SHELLDETAILS sd; SHELLDETAILS sd;
WCHAR wszItem1[MAX_PATH], wszItem2[MAX_PATH]; WCHAR wszItem1[MAX_PATH], wszItem2[MAX_PATH];
HRESULT hres; HRESULT hres;
UINT col = LOWORD(lParam); // Column index without SHCIDS_* flags
hres = isf->GetDetailsOf(pidl1, lParam, &sd); hres = isf->GetDetailsOf(pidl1, col, &sd);
if (FAILED(hres)) if (FAILED(hres))
return MAKE_COMPARE_HRESULT(1); return MAKE_COMPARE_HRESULT(1);
@ -250,7 +251,7 @@ HRESULT SHELL32_CompareDetails(IShellFolder2* isf, LPARAM lParam, LPCITEMIDLIST
if (FAILED(hres)) if (FAILED(hres))
return MAKE_COMPARE_HRESULT(1); return MAKE_COMPARE_HRESULT(1);
hres = isf->GetDetailsOf(pidl2, lParam, &sd); hres = isf->GetDetailsOf(pidl2, col, &sd);
if (FAILED(hres)) if (FAILED(hres))
return MAKE_COMPARE_HRESULT(1); return MAKE_COMPARE_HRESULT(1);