From 3384b413abb72490788f5f91c5f4ecf0a57f92f2 Mon Sep 17 00:00:00 2001 From: Thomas Bluemel Date: Sat, 14 Jan 2006 23:37:56 +0000 Subject: [PATCH] fixed a buffer overflow when the referenced domain length is 0 svn path=/trunk/; revision=20872 --- reactos/subsys/system/cacls/cacls.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/reactos/subsys/system/cacls/cacls.c b/reactos/subsys/system/cacls/cacls.c index 3751ebaf310..25e89afe88c 100644 --- a/reactos/subsys/system/cacls/cacls.c +++ b/reactos/subsys/system/cacls/cacls.c @@ -248,7 +248,7 @@ PrintFileDacl(IN LPTSTR FilePath, &DomainSize, &Use)) { - if (GetLastError() == ERROR_NONE_MAPPED) + if (GetLastError() == ERROR_NONE_MAPPED || NameSize == 0) { goto BuildSidString; } @@ -271,7 +271,9 @@ PrintFileDacl(IN LPTSTR FilePath, } Domain = Name + NameSize; - Name[0] = Domain[0] = _T('\0'); + Name[0] = _T('\0'); + if (DomainSize != 0) + Domain[0] = _T('\0'); if (!LookupAccountSid(NULL, Sid, Name,