Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-06-30 09:50:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

- fix potential buffer overflows spotted by Christoph

Browse source 
svn path=/trunk/; revision=34344
This commit is contained in:
Johannes Anderwald 2008-07-06 20:52:11 +00:00
parent cce8a43337
commit 2f76e8ade2
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
reactos/dll/win32/shell32/fprop.c
View file

@ -678,13 +678,16 @@ EnumPropSheetExt(LPWSTR wFileName, HPROPSHEETPAGE * hppages, int NumPages, HPSXA
pOffset = wcsrchr(wFileName, L'.');
if (!pOffset)
{
Length = wcslen(szName);
if (Length >=94)
return 0;
wcscpy(szName, L"CLSID\\");
wcscpy(&szName[6], wFileName);
}
else
{
Length = wcslen(pOffset);
if (Length >= 70)
if (Length >= 100)
return 0;
wcscpy(szName, pOffset);
}
@ -700,6 +703,7 @@ EnumPropSheetExt(LPWSTR wFileName, HPROPSHEETPAGE * hppages, int NumPages, HPSXA
if (RegGetValueW(HKEY_CLASSES_ROOT, pOffset, NULL, RRF_RT_REG_SZ, NULL, szName, &dwName) == ERROR_SUCCESS)
{
TRACE("EnumPropSheetExt szName %s, pOffset %s\n", debugstr_w(szName), debugstr_w(pOffset));
szName[(sizeof(szName)/sizeof(WCHAR))-1] = L'\0';
hpsxa[1] = SHCreatePropSheetExtArrayEx(HKEY_CLASSES_ROOT, szName, NumPages - Pages, pDataObj);
Pages +=SHAddFromPropSheetExtArray(hpsxa[1], AddShellPropSheetExCallback, (LPARAM)hppages);
}