Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-03 20:25:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

- Check if NodeId is out of bounds

Browse source 
- Return correct status code

svn path=/trunk/; revision=43253
This commit is contained in:
Johannes Anderwald 2009-10-02 10:53:36 +00:00
parent 9ef3f7c1a2
commit 2f541881a8
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
reactos/drivers/ksfilter/ks/topology.c
View file

@ -241,6 +241,13 @@ KsTopologyPropertyHandler(
case KSPROPERTY_TOPOLOGY_NAME: case KSPROPERTY_TOPOLOGY_NAME:
Node = (KSP_NODE*)Property; Node = (KSP_NODE*)Property;
if (Node->NodeId >= Topology->TopologyNodesCount)
{
Irp->IoStatus.Information = 0;
Status = STATUS_INVALID_PARAMETER;
break;
}
Status = RtlStringFromGUID(&Topology->TopologyNodesNames[Node->NodeId], &GuidString); Status = RtlStringFromGUID(&Topology->TopologyNodesNames[Node->NodeId], &GuidString);
if (!NT_SUCCESS(Status)) if (!NT_SUCCESS(Status))
{ {
@ -254,6 +261,7 @@ KsTopologyPropertyHandler(
if (!KeyName.Buffer) if (!KeyName.Buffer)
{ {
Irp->IoStatus.Information = 0; Irp->IoStatus.Information = 0;
Status = STATUS_INSUFFICIENT_RESOURCES;
break; break;
} }