From 2c399da91675f8bd8ce49e6930c2bc92bf2bfa7b Mon Sep 17 00:00:00 2001 From: Ged Murphy Date: Wed, 29 Apr 2009 10:18:41 +0000 Subject: [PATCH] Fix the build and a fix mem leak. We should consider setting msvc to /W4. svn path=/trunk/; revision=40730 --- reactos/base/applications/mscutils/servman/control.c | 2 +- reactos/base/applications/mscutils/servman/stop.c | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/reactos/base/applications/mscutils/servman/control.c b/reactos/base/applications/mscutils/servman/control.c index a170e80a52f..8ccf6fc43f4 100644 --- a/reactos/base/applications/mscutils/servman/control.c +++ b/reactos/base/applications/mscutils/servman/control.c @@ -16,7 +16,7 @@ Control(PMAIN_WND_INFO Info, { SC_HANDLE hSCManager; SC_HANDLE hSc; - SERVICE_STATUS_PROCESS ServiceStatus; + SERVICE_STATUS_PROCESS ServiceStatus = {0}; SERVICE_STATUS Status; DWORD BytesNeeded = 0; BOOL bRet = FALSE; diff --git a/reactos/base/applications/mscutils/servman/stop.c b/reactos/base/applications/mscutils/servman/stop.c index 64b60e97e01..a2ff4713ff6 100644 --- a/reactos/base/applications/mscutils/servman/stop.c +++ b/reactos/base/applications/mscutils/servman/stop.c @@ -197,8 +197,6 @@ static BOOL DoInitDependsDialog(PSTOP_INFO pStopInfo, HWND hDlg) { - SC_HANDLE hSCManager; - SC_HANDLE hService; LPENUM_SERVICE_STATUS lpDependencies; DWORD dwCount; LPTSTR lpPartialStr, lpStr; @@ -277,6 +275,10 @@ DoInitDependsDialog(PSTOP_INFO pStopInfo, 0, (LPARAM)lpEnumServiceStatus->lpDisplayName); } + + HeapFree(ProcessHeap, + 0, + lpDependencies); } } @@ -340,7 +342,6 @@ DoStop(PMAIN_WND_INFO pInfo) STOP_INFO stopInfo; SC_HANDLE hSCManager; SC_HANDLE hService; - BOOL bHasDepends; BOOL bRet = FALSE; if (pInfo)