Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-31 19:42:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

[RAPPS] Remove deprecated TODO; use _countof() where needed.

Browse source
This commit is contained in:
Hermès Bélusca-Maïto 2018-02-03 23:40:58 +01:00
parent 3f5fe94104
commit 26ac8ac81e
No known key found for this signature in database
GPG key ID: 3B2539C65E7B93D0
5 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
base/applications/rapps/gui.cpp
View file

@ -145,7 +145,6 @@ class CAvailableAppView
szLoadedAInfoText.LoadStringW(IDS_AINFO_LANGUAGES); szLoadedAInfoText.LoadStringW(IDS_AINFO_LANGUAGES);
//TODO: replace those hardcoded strings
if (Info->HasNativeLanguage()) if (Info->HasNativeLanguage())
{ {
szLoadedTextAvailability.LoadStringW(IDS_LANGUAGE_AVAILABLE_TRANSLATION); szLoadedTextAvailability.LoadStringW(IDS_LANGUAGE_AVAILABLE_TRANSLATION);

2
base/applications/rapps/loaddlg.cpp
View file

@ -444,7 +444,7 @@ INT_PTR CALLBACK CDownloadManager::DownloadDlgProc(HWND Dlg, UINT uMsg, WPARAM w
DownloadsListView.LoadList(AppsToInstallList); DownloadsListView.LoadList(AppsToInstallList);
// Get a dlg string for later use // Get a dlg string for later use
GetWindowTextW(Dlg, szCaption, MAX_PATH); GetWindowTextW(Dlg, szCaption, _countof(szCaption));
// Hide a placeholder from displaying // Hide a placeholder from displaying
szTempCaption = szCaption; szTempCaption = szCaption;

2
base/applications/rapps/misc.cpp
View file

@ -225,7 +225,7 @@ BOOL ExtractFilesFromCab(LPCWSTR lpCabName, LPCWSTR lpOutputPath)
ZeroMemory(&Dest, sizeof(Dest)); ZeroMemory(&Dest, sizeof(Dest));
WideCharToMultiByte(CP_ACP, 0, lpOutputPath, -1, Dest.Destination, MAX_PATH, NULL, NULL); WideCharToMultiByte(CP_ACP, 0, lpOutputPath, -1, Dest.Destination, MAX_PATH, NULL, NULL);
WideCharToMultiByte(CP_ACP, 0, lpCabName, -1, szCabName, MAX_PATH, NULL, NULL); WideCharToMultiByte(CP_ACP, 0, lpCabName, -1, szCabName, _countof(szCabName), NULL, NULL);
Dest.Operation = EXTRACT_FILLFILELIST; Dest.Operation = EXTRACT_FILLFILELIST;
Result = pfnExtract(&Dest, szCabName); Result = pfnExtract(&Dest, szCabName);

2
base/applications/rapps/splitter.cpp
View file

@ -147,7 +147,6 @@ CreateHSplitBar(HWND hwnd)
hInst, hInst,
NULL); NULL);
if (hHSplitter == NULL) if (hHSplitter == NULL)
{ {
/* TODO: Show error message */ /* TODO: Show error message */
@ -288,7 +287,6 @@ CreateVSplitBar(HWND hwnd)
hInst, hInst,
NULL); NULL);
if (!hVSplitter) if (!hVSplitter)
{ {
/* TODO: Show error message */ /* TODO: Show error message */

2
base/applications/rapps/unattended.cpp
View file

@ -47,7 +47,7 @@ BOOL UseCmdParameters(LPWSTR lpCmdLine)
WCHAR szName[MAX_PATH]; WCHAR szName[MAX_PATH];
do do
{ {
if (SetupGetStringFieldW(&Context, 1, szName, MAX_PATH, NULL)) if (SetupGetStringFieldW(&Context, 1, szName, _countof(szName), NULL))
{ {
arrNames.Add(szName); arrNames.Add(szName);
} }