Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-08-01 17:11:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

NtUserBuildHwndList:

Browse source 
- non-recursive implementation, which saves stack space and should be about twice as fast.
- use SEH instead of MmCopyToCaller

svn path=/trunk/; revision=26336
This commit is contained in:
Timo Kreuzer 2007-04-14 00:06:21 +00:00
parent 595f645cca
commit 2693be107f
1 changed files with 48 additions and 46 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

94
reactos/subsystems/win32/win32k/ntuser/window.c
View file

@ -1128,43 +1128,6 @@ NtUserAlterWindowStyle(DWORD Unknown0,
return(0);
}
STATIC
ULONG
STDCALL
IntBuildHwndList(
PWINDOW_OBJECT Window,
BOOLEAN bChildren,
HWND* pWnd,
ULONG nBufSize)
{
NTSTATUS Status;
PWINDOW_OBJECT Child;
ULONG dwInc, dwCount = 0;
for(Child = Window->FirstChild; Child != NULL; Child = Child->NextSibling)
{
if(dwCount++ < nBufSize && pWnd)
{
Status = MmCopyToCaller(pWnd++, &Child->hSelf, sizeof(HWND));
if(!NT_SUCCESS(Status))
{
SetLastNtError(Status);
break;
}
}
if (bChildren)
{
dwInc = IntBuildHwndList(Child,
bChildren,
pWnd,
nBufSize > dwCount ? nBufSize - dwCount : 0);
dwCount += dwInc;
pWnd += dwInc;
}
}
return dwCount;
}
/*
* As best as I can figure, this function is used by EnumWindows,
* EnumChildWindows, EnumDesktopWindows, & EnumThreadWindows.
@ -1193,7 +1156,7 @@ NtUserBuildHwndList(
if (hwndParent || !dwThreadId)
{
PDESKTOP_OBJECT Desktop;
PWINDOW_OBJECT Window;
PWINDOW_OBJECT Parent, Window;
if(!hwndParent)
{
@ -1222,16 +1185,55 @@ NtUserBuildHwndList(
hDesktop = 0;
}
if(!(Window = UserGetWindowObject(hwndParent)))
if((Parent = UserGetWindowObject(hwndParent)) &&
(Window = Parent->FirstChild))
{
if(hDesktop)
{
ObDereferenceObject(Desktop);
}
return 0;
}
BOOL bGoDown = TRUE;
dwCount = IntBuildHwndList(Window, bChildren, pWnd, nBufSize);
Status = STATUS_SUCCESS;
while(TRUE)
{
if (bGoDown)
{
if(dwCount++ < nBufSize && pWnd)
{
_SEH_TRY
{
ProbeForWrite(pWnd, sizeof(HWND), 1);
*pWnd = Window->hSelf;
pWnd++;
}
_SEH_HANDLE
{
Status = _SEH_GetExceptionCode();
}
_SEH_END
if(!NT_SUCCESS(Status))
{
SetLastNtError(Status);
break;
}
}
if (Window->FirstChild && bChildren)
{
Window = Window->FirstChild;
continue;
}
bGoDown = FALSE;
}
if (Window->NextSibling)
{
Window = Window->NextSibling;
bGoDown = TRUE;
continue;
}
Window = Window->Parent;
if (Window == Parent)
{
break;
}
}
}
if(hDesktop)
{