Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-26 00:54:40 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix string returned by IopGetParentIdPrefix, which was sometimes badly initialized

Browse source 
svn path=/trunk/; revision=19106
This commit is contained in:
Hervé Poussineau 2005-11-09 21:18:08 +00:00
parent e7bbce753f
commit 259f79e3d8
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
reactos/ntoskrnl/io/pnpmgr.c
View file

@ -1406,21 +1406,29 @@ IopGetParentIdPrefix(
{
if (ParentIdPrefixInformation->Type != REG_SZ)
Status = STATUS_UNSUCCESSFUL;
else
{
KeyValue.Length = KeyValue.MaximumLength = ParentIdPrefixInformation->DataLength;
KeyValue.Buffer = (PWSTR)ParentIdPrefixInformation->Data;
}
goto cleanup;
}
if (Status != STATUS_OBJECT_NAME_NOT_FOUND)
{
KeyValue.Length = KeyValue.MaximumLength = ParentIdPrefixInformation->DataLength;
KeyValue.Buffer = (PWSTR)ParentIdPrefixInformation->Data;
goto cleanup;
}
/* 2. Create the ParentIdPrefix value */
currentByte = (PBYTE)DeviceNode->Parent->InstancePath.Buffer;
for (i = 0; i < DeviceNode->Parent->InstancePath.Length; i++, currentByte++)
crc32 = (crc32 >> 8) ^ crc32Table[*currentByte ^ (crc32 & 0xff)];
crc32 = ~crc32;
KeyValue.Buffer = (PWSTR)ParentIdPrefixInformation->Data;
swprintf(KeyValue.Buffer, L"%lx&%lx", DeviceNode->Parent->Level, crc32);
swprintf((PWSTR)ParentIdPrefixInformation->Data, L"%lx&%lx", DeviceNode->Parent->Level, crc32);
RtlInitUnicodeString(&KeyValue, (PWSTR)ParentIdPrefixInformation->Data);
/* 3. Try to write the ParentIdPrefix to registry */
RtlInitUnicodeString(&KeyValue, KeyValue.Buffer);
Status = ZwSetValueKey(
hKey, &ValueName,
0, REG_SZ,
@ -1431,8 +1439,6 @@ cleanup:
if (NT_SUCCESS(Status))
{
/* Duplicate the string to return it */
KeyValue.Length = KeyValue.MaximumLength = ParentIdPrefixInformation->DataLength;
KeyValue.Buffer = (PWSTR)ParentIdPrefixInformation->Data;
Status = RtlDuplicateUnicodeString(RTL_DUPLICATE_UNICODE_STRING_NULL_TERMINATE, &KeyValue, ParentIdPrefix);
}
ExFreePool(ParentIdPrefixInformation);