Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-05-25 12:14:32 +00:00
Code Issues Projects Releases Packages Wiki Activity

[CRT] Do Not lock ioinfo when spawning functions (#4099) CORE-15176

Browse source 
This fixes CORE-15176 'Gimp 2.6.11 hangs when opening a file'.
It regressed by 0.4.9-dev-446-g bffd8201d0

I do intend to port this fix back.
This commit is contained in:
Doug Lyons 2021-11-11 11:30:43 -06:00 committed by GitHub
parent 0ae3805375
commit 252a7530d0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
sdk/lib/crt/stdio/file.c
View file

@ -434,7 +434,7 @@ unsigned create_io_inherit_block(WORD *size, BYTE **block)
for (fd = 0; fd < last_fd; fd++) for (fd = 0; fd < last_fd; fd++)
{ {
/* to be inherited, we need it to be open, and that DONTINHERIT isn't set */ /* to be inherited, we need it to be open, and that DONTINHERIT isn't set */
fdinfo = get_ioinfo(fd); fdinfo = get_ioinfo_nolock(fd);
if ((fdinfo->wxflag & (WX_OPEN | WX_DONTINHERIT)) == WX_OPEN) if ((fdinfo->wxflag & (WX_OPEN | WX_DONTINHERIT)) == WX_OPEN)
{ {
*wxflag_ptr = fdinfo->wxflag; *wxflag_ptr = fdinfo->wxflag;
@ -445,7 +445,6 @@ unsigned create_io_inherit_block(WORD *size, BYTE **block)
*wxflag_ptr = 0; *wxflag_ptr = 0;
*handle_ptr = INVALID_HANDLE_VALUE; *handle_ptr = INVALID_HANDLE_VALUE;
} }
release_ioinfo(fdinfo);
wxflag_ptr++; handle_ptr++; wxflag_ptr++; handle_ptr++;
} }
return TRUE; return TRUE;