Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-07-30 21:51:47 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NTOS:MM] Handle failure of MmSetPageEntrySectionSegment

Browse source 
This prevents a crash when paged pool is low.

No, I will not fix all other instances!
This commit is contained in:
Timo Kreuzer 2025-06-25 14:46:09 +03:00
parent 2cd05a3756
commit 24b0857a72
1 changed files with 25 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

31
ntoskrnl/mm/section.c
View file

@ -53,10 +53,8 @@
#include "ARM3/miarm.h"
#undef MmSetPageEntrySectionSegment
#define MmSetPageEntrySectionSegment(S,O,E) do { \
DPRINT("SetPageEntrySectionSegment(old,%p,%x,%x)\n",(S),(O)->LowPart,E); \
_MmSetPageEntrySectionSegment((S),(O),(E),__FILE__,__LINE__); \
} while (0)
#define MmSetPageEntrySectionSegment(S,O,E) \
_MmSetPageEntrySectionSegment((S),(O),(E),__FILE__,__LINE__)
extern MMSESSION MmSession;
@ -1263,14 +1261,35 @@ MmMakeSegmentResident(
{
/* Dirtify it if it's a resident page and we're asked to */
if (SetDirty && !IS_SWAP_FROM_SSE(Entry))
MmSetPageEntrySectionSegment(Segment, &CurrentOffset, DIRTY_SSE(Entry));
{
NT_VERIFY(NT_SUCCESS(MmSetPageEntrySectionSegment(Segment, &CurrentOffset, DIRTY_SSE(Entry))));
}
continue;
}
ToReadPageBits |= 1UL << ((ChunkOffset - RangeStart) >> PAGE_SHIFT);
/* Put a wait entry here */
MmSetPageEntrySectionSegment(Segment, &CurrentOffset, MAKE_SWAP_SSE(MM_WAIT_ENTRY));
Status = MmSetPageEntrySectionSegment(Segment, &CurrentOffset, MAKE_SWAP_SSE(MM_WAIT_ENTRY));
if (!NT_SUCCESS(Status))
{
/* Failed, roll back! */
DPRINT1("Failed to set wait entry for segment %p at offset %I64d\n", Segment, ChunkOffset);
LARGE_INTEGER RollbackOffset;
RollbackOffset.QuadPart = ChunkOffset;
while (RollbackOffset.QuadPart > RangeStart)
{
RollbackOffset.QuadPart -= PAGE_SIZE;
if (MM_IS_WAIT_PTE(MmGetPageEntrySectionSegment(Segment, &RollbackOffset)))
{
NT_VERIFY(NT_SUCCESS(MmSetPageEntrySectionSegment(Segment, &RollbackOffset, 0)));
}
}
MmUnlockSectionSegment(Segment);
return Status;
}
ASSERT(MM_IS_WAIT_PTE(MmGetPageEntrySectionSegment(Segment, &CurrentOffset)));
}
MmUnlockSectionSegment(Segment);