Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-22 08:25:03 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NTGDI] Fix stack memory disclosure in ftGdiGetTextMetricsW (#2991)

Browse source
This commit is contained in:
Nguyen Trung Khanh 2020-08-25 23:28:39 +07:00 committed by GitHub
parent a081e12fbd
commit 247c189263
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
win32ss/gdi/ntgdi/freetype.c
View file

@ -4560,6 +4560,7 @@ ftGdiGetTextMetricsW(
EngSetLastError(STATUS_INVALID_PARAMETER); EngSetLastError(STATUS_INVALID_PARAMETER);
return FALSE; return FALSE;
} }
RtlZeroMemory(ptmwi, sizeof(TMW_INTERNAL));
if (!(dc = DC_LockDc(hDC))) if (!(dc = DC_LockDc(hDC)))
{ {
@ -4612,7 +4613,6 @@ ftGdiGetTextMetricsW(
FillTM(&ptmwi->TextMetric, FontGDI, pOS2, pHori, !Error ? &Win : 0); FillTM(&ptmwi->TextMetric, FontGDI, pOS2, pHori, !Error ? &Win : 0);
/* FIXME: Fill Diff member */ /* FIXME: Fill Diff member */
RtlZeroMemory(&ptmwi->Diff, sizeof(ptmwi->Diff));
} }
IntUnLockFreeType(); IntUnLockFreeType();