attribute 'first' of <file> must be 'true' or 'false'

remove an obsolete comment

svn path=/branches/xmlbuildsystem/; revision=13191
This commit is contained in:
Royce Mitchell III 2005-01-21 18:15:10 +00:00
parent f7201d8993
commit 23a949dd32
3 changed files with 12 additions and 4 deletions

View file

@ -29,7 +29,7 @@
<directory name="ke"> <directory name="ke">
<if property="ARCH" value="i386"> <if property="ARCH" value="i386">
<directory name="i386"> <directory name="i386">
<file first="1">multiboot.S</file> <file first="true">multiboot.S</file>
<file>bios.c</file> <file>bios.c</file>
<file>brkpoint.c</file> <file>brkpoint.c</file>
<file>bthread.S</file> <file>bthread.S</file>

View file

@ -628,7 +628,6 @@ XMLReadFile ( XMLFile& f, XMLElement& head, XMLIncludes& includes, const Path& p
XMLElement* XMLElement*
XMLLoadInclude ( XMLElement* e, const Path& path, XMLIncludes& includes ) XMLLoadInclude ( XMLElement* e, const Path& path, XMLIncludes& includes )
{ {
// TODO FIXME
XMLAttribute* att; XMLAttribute* att;
att = e->GetAttribute("href",true); att = e->GetAttribute("href",true);
assert(att); assert(att);

View file

@ -111,9 +111,18 @@ Module::ProcessXMLSubElement ( const XMLElement& e,
string subpath ( path ); string subpath ( path );
if ( e.name == "file" && e.value.size () > 0 ) if ( e.name == "file" && e.value.size () > 0 )
{ {
bool first = false;
const XMLAttribute* att = e.GetAttribute ( "first", false ); const XMLAttribute* att = e.GetAttribute ( "first", false );
File* pFile = new File ( FixSeparator ( path + CSEP + e.value ), if ( att )
att && atoi(att->value.c_str()) != 0 ); {
if ( !stricmp ( att->value.c_str(), "true" ) )
first = true;
else if ( stricmp ( att->value.c_str(), "false" ) )
throw InvalidBuildFileException (
e.location,
"attribute 'first' of <file> element can only be 'true' or 'false'" );
}
File* pFile = new File ( FixSeparator ( path + CSEP + e.value ), first );
if ( pIf ) if ( pIf )
pIf->files.push_back ( pFile ); pIf->files.push_back ( pFile );
else else