Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-04-04 12:39:35 +00:00
Code Issues Projects Releases Packages Wiki Activity

[KERNEL32] Minor comments improvements in CreateProcessInternalW.

Browse source
This commit is contained in:
Hermès Bélusca-Maïto 2023-05-17 13:56:12 +02:00
parent 56e93b882d
commit 1cbcc4ac5c
No known key found for this signature in database
GPG key ID: 3B2539C65E7B93D0
1 changed files with 9 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
dll/win32/kernel32/client/proc.c
View file

@ -2222,8 +2222,8 @@ ProcessIdToSessionId(IN DWORD dwProcessId,
} }
#define AddToHandle(x,y) (x) = (HANDLE)((ULONG_PTR)(x) | (y)); #define AddToHandle(x,y) ((x) = (HANDLE)((ULONG_PTR)(x) | (y)))
#define RemoveFromHandle(x,y) (x) = (HANDLE)((ULONG_PTR)(x) & ~(y)); #define RemoveFromHandle(x,y) ((x) = (HANDLE)((ULONG_PTR)(x) & ~(y)))
C_ASSERT(PROCESS_PRIORITY_CLASS_REALTIME == (PROCESS_PRIORITY_CLASS_HIGH + 1)); C_ASSERT(PROCESS_PRIORITY_CLASS_REALTIME == (PROCESS_PRIORITY_CLASS_HIGH + 1));
/* /*
@ -4279,13 +4279,12 @@ StartScan:
} }
} }
/* For all apps, if this flag is on, the hourglass mouse cursor is shown */ /* For all apps, if this flag is on, the hourglass mouse cursor is shown.
* Likewise, the opposite holds as well, and no-feedback has precedence. */
if (StartupInfo.dwFlags & STARTF_FORCEONFEEDBACK) if (StartupInfo.dwFlags & STARTF_FORCEONFEEDBACK)
{ {
AddToHandle(CreateProcessMsg->ProcessHandle, 1); AddToHandle(CreateProcessMsg->ProcessHandle, 1);
} }
/* Likewise, the opposite holds as well */
if (StartupInfo.dwFlags & STARTF_FORCEOFFFEEDBACK) if (StartupInfo.dwFlags & STARTF_FORCEOFFFEEDBACK)
{ {
RemoveFromHandle(CreateProcessMsg->ProcessHandle, 1); RemoveFromHandle(CreateProcessMsg->ProcessHandle, 1);
@ -4297,8 +4296,8 @@ StartScan:
/* And if it really is a VDM app... */ /* And if it really is a VDM app... */
if (VdmBinaryType) if (VdmBinaryType)
{ {
/* Store the task ID and VDM console handle */ /* Store the VDM console handle (none if inherited or WOW app) and the task ID */
CreateProcessMsg->hVDM = VdmTask ? 0 : Peb->ProcessParameters->ConsoleHandle; CreateProcessMsg->hVDM = VdmTask ? NULL : Peb->ProcessParameters->ConsoleHandle;
CreateProcessMsg->VdmTask = VdmTask; CreateProcessMsg->VdmTask = VdmTask;
} }
else if (VdmReserve) else if (VdmReserve)
@ -4410,10 +4409,9 @@ VdmShortCircuit:
} }
else else
{ {
/* OR-in the special flag to indicate this is not a separate VDM */ /* OR-in the special flag to indicate this is not a separate VDM,
* and return the handle to the caller */
AddToHandle(VdmWaitObject, 1); AddToHandle(VdmWaitObject, 1);
/* Return handle to the caller */
lpProcessInformation->hProcess = VdmWaitObject; lpProcessInformation->hProcess = VdmWaitObject;
} }
@ -4524,7 +4522,7 @@ Quickie:
if (ThreadHandle) if (ThreadHandle)
{ {
/* So kill the process and close the thread handle */ /* So kill the process and close the thread handle */
NtTerminateProcess(ProcessHandle, 0); NtTerminateProcess(ProcessHandle, STATUS_SUCCESS);
NtClose(ThreadHandle); NtClose(ThreadHandle);
} }