From 19a0f14bb19403e29d1a43757f7cf5dab4e397d8 Mon Sep 17 00:00:00 2001 From: Whindmar Saksit Date: Sun, 17 Dec 2023 13:48:24 +0100 Subject: [PATCH] [SHELL32] ShellDispatch::ShellExecute must default to displaying the window (#6143) SW_HIDE is not the correct default show mode. This can be reproduced by simple script: WScript.CreateObject("Shell.Application").ShellExecute("calc.exe"); --- dll/win32/shell32/CShellDispatch.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dll/win32/shell32/CShellDispatch.cpp b/dll/win32/shell32/CShellDispatch.cpp index d021bf5ea2b..7df94e0ae04 100644 --- a/dll/win32/shell32/CShellDispatch.cpp +++ b/dll/win32/shell32/CShellDispatch.cpp @@ -245,7 +245,7 @@ HRESULT STDMETHODCALLTYPE CShellDispatch::ShellExecute(BSTR file, VARIANT v_args { CComVariant args_str, dir_str, op_str, show_int; WCHAR *args = NULL, *dir = NULL, *op = NULL; - INT show = 0; + INT show = SW_SHOW; HINSTANCE ret; TRACE("(%s, %s, %s, %s, %s)\n", debugstr_w(file), debugstr_variant(&v_args),