Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-07 04:03:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

[SHELL32] Fix some clang warnings (#7845)

Browse source
This commit is contained in:
Whindmar Saksit 2025-03-31 18:59:04 +02:00 • committed by GitHub
parent aa4fac61c8
commit 190782c3e0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
14 changed files with 22 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

7
dll/win32/shell32/CDefView.cpp
View file

@ -518,7 +518,7 @@ public:
return wc;
}
virtual WNDPROC GetWindowProc()
virtual WNDPROC GetWindowProc() override
{
return WindowProc;
}
@ -1059,7 +1059,7 @@ HRESULT CDefView::GetDetailsByFolderColumn(PCUITEMID_CHILD pidl, UINT FoldCol, S
{
// According to learn.microsoft.com/en-us/windows/win32/shell/sfvm-getdetailsof
// the query order is IShellFolder2, IShellDetails, SFVM_GETDETAILSOF.
HRESULT hr;
HRESULT hr = E_FAIL;
if (m_pSF2Parent)
{
hr = m_pSF2Parent->GetDetailsOf(pidl, FoldCol, &sd);
@ -1230,6 +1230,7 @@ void CDefView::ColumnListChanged()
break;
HRESULT foldCol = MapListColumnToFolderColumn(listCol);
assert(SUCCEEDED(foldCol));
DBG_UNREFERENCED_LOCAL_VARIABLE(foldCol);
AppendMenuItem(m_hMenuArrangeModes, MF_STRING,
DVIDM_ARRANGESORT_FIRST + listCol, lvc.pszText, listCol);
}
@ -3373,7 +3374,7 @@ HRESULT CDefView::LoadViewState()
m_LoadColumnsList = NULL;
}
}
m_sortInfo.bLoadedFromViewState = !fallback && m_LoadColumnsList && cvs.SortColId != LISTVIEW_SORT_INFO::UNSPECIFIEDCOLUMN;
m_sortInfo.bLoadedFromViewState = !fallback && m_LoadColumnsList && (int)cvs.SortColId != LISTVIEW_SORT_INFO::UNSPECIFIEDCOLUMN;
m_sortInfo.bColumnIsFolderColumn = TRUE;
m_sortInfo.Direction = cvs.SortDir > 0 ? 1 : -1;
m_sortInfo.ListColumn = cvs.SortColId;