[SERVICES]

Revert r49366.

svn path=/trunk/; revision=49371

reactos/base/system/services/database.c

@@ -678,8 +678,64 @@ ScmGetBootAndSystemDriverState(VOID)
 
 
 DWORD
-ScmSendServiceCommand(PSERVICE Service,
+ScmControlService(PSERVICE Service,
-                      DWORD dwControl,
+                  DWORD dwControl)
+{
+    PSCM_CONTROL_PACKET ControlPacket;
+    SCM_REPLY_PACKET ReplyPacket;
+
+    DWORD dwWriteCount = 0;
+    DWORD dwReadCount = 0;
+    DWORD TotalLength;
+    DWORD dwError = ERROR_SUCCESS;
+
+    DPRINT("ScmControlService() called\n");
+
+    TotalLength = wcslen(Service->lpServiceName) + 1;
+
+    ControlPacket = (SCM_CONTROL_PACKET*)HeapAlloc(GetProcessHeap(),
+                                                   HEAP_ZERO_MEMORY,
+                                                   sizeof(SCM_CONTROL_PACKET) + (TotalLength * sizeof(WCHAR)));
+    if (ControlPacket == NULL)
+        return ERROR_NOT_ENOUGH_MEMORY;
+
+    ControlPacket->dwControl = dwControl;
+    ControlPacket->dwSize = TotalLength;
+    ControlPacket->hServiceStatus = (SERVICE_STATUS_HANDLE)Service;
+    wcscpy(&ControlPacket->szArguments[0], Service->lpServiceName);
+
+    /* Send the control packet */
+    WriteFile(Service->ControlPipeHandle,
+              ControlPacket,
+              sizeof(SCM_CONTROL_PACKET) + (TotalLength * sizeof(WCHAR)),
+              &dwWriteCount,
+              NULL);
+
+    /* Read the reply */
+    ReadFile(Service->ControlPipeHandle,
+             &ReplyPacket,
+             sizeof(SCM_REPLY_PACKET),
+             &dwReadCount,
+             NULL);
+
+    /* Release the contol packet */
+    HeapFree(GetProcessHeap(),
+             0,
+             ControlPacket);
+
+    if (dwReadCount == sizeof(SCM_REPLY_PACKET))
+    {
+        dwError = ReplyPacket.dwError;
+    }
+
+    DPRINT("ScmControlService() done\n");
+
+    return dwError;
+}
+
+
+static DWORD
+ScmSendStartCommand(PSERVICE Service,
                     DWORD argc,
                     LPWSTR *argv)
 {
@@ -694,7 +750,7 @@ ScmSendServiceCommand(PSERVICE Service,
     DWORD dwError = ERROR_SUCCESS;
     DWORD i;
 
-    DPRINT("ScmSendServiceCommand() called\n");
+    DPRINT("ScmSendStartCommand() called\n");
 
     /* Calculate the total length of the start command line */
     TotalLength = wcslen(Service->lpServiceName) + 1;
@@ -718,7 +774,7 @@ ScmSendServiceCommand(PSERVICE Service,
     if (ControlPacket == NULL)
         return ERROR_NOT_ENOUGH_MEMORY;
 
-    ControlPacket->dwControl = dwControl;
+    ControlPacket->dwControl = SERVICE_CONTROL_START;
     ControlPacket->hServiceStatus = (SERVICE_STATUS_HANDLE)Service;
     ControlPacket->dwSize = TotalLength;
     Ptr = &ControlPacket->szArguments[0];
@@ -763,7 +819,7 @@ ScmSendServiceCommand(PSERVICE Service,
         dwError = ReplyPacket.dwError;
     }
 
-    DPRINT("ScmSendServiceCommand() done\n");
+    DPRINT("ScmSendStartCommand() done\n");
 
     return dwError;
 }
@@ -942,10 +998,7 @@ ScmStartUserModeService(PSERVICE Service,
             DPRINT("Received service process ID %lu\n", dwProcessId);
 
             /* Send start command */
-            dwError = ScmSendServiceCommand(Service,
+            dwError = ScmSendStartCommand(Service, argc, argv);
-                                            SERVICE_CONTROL_START,
-                                            argc,
-                                            argv);
         }
     }
     else
@@ -1174,10 +1227,7 @@ ScmAutoShutdownServices(VOID)
             CurrentService->Status.dwCurrentState == SERVICE_START_PENDING)
         {
             /* shutdown service */
-            ScmSendServiceCommand(CurrentService,
+            ScmControlService(CurrentService, SERVICE_CONTROL_STOP);
-                                  SERVICE_CONTROL_STOP,
-                                  0,
-                                  NULL);
         }
 
         ServiceEntry = ServiceEntry->Flink;

reactos/base/system/services/rpcserver.c

@@ -699,10 +699,8 @@ DWORD RControlService(
         }
 
         /* Send control code to the service */
-        dwError = ScmSendServiceCommand(lpService,
+        dwError = ScmControlService(lpService,
-                                        dwControl,
+                                    dwControl);
-                                        0,
-                                        NULL);
 
         /* Return service status information */
         RtlCopyMemory(lpServiceStatus,
@@ -2866,10 +2864,7 @@ DWORD RStartServiceW(
     }
 
     /* Start the service */
-    dwError = ScmSendServiceCommand(lpService,
+    dwError = ScmStartService(lpService, argc, (LPWSTR *)argv);
-                                    SERVICE_CONTROL_START,
-                                    argc,
-                                    (LPWSTR *)argv);
 
     return dwError;
 }
@@ -4077,10 +4072,7 @@ DWORD RStartServiceA(
     /* FIXME: Convert argument vector to Unicode */
 
     /* Start the service */
-    dwError = ScmSendServiceCommand(lpService,
+    dwError = ScmStartService(lpService, 0, NULL);
-                                    SERVICE_CONTROL_START,
-                                    0,
-                                    NULL);
 
     /* FIXME: Free argument vector */
 

reactos/base/system/services/services.h

@@ -104,8 +104,7 @@ VOID ScmShutdownServiceDatabase(VOID);
 VOID ScmGetBootAndSystemDriverState(VOID);
 VOID ScmAutoStartServices(VOID);
 VOID ScmAutoShutdownServices(VOID);
-DWORD ScmSendServiceCommand(PSERVICE Service,
+DWORD ScmStartService(PSERVICE Service,
-                            DWORD dwControl,
                       DWORD argc,
                       LPWSTR *argv);
 
@@ -117,6 +116,9 @@ DWORD ScmCreateNewServiceRecord(LPCWSTR lpServiceName,
 VOID ScmDeleteServiceRecord(PSERVICE lpService);
 DWORD ScmMarkServiceForDelete(PSERVICE pService);
 
+DWORD ScmControlService(PSERVICE Service,
+                        DWORD dwControl);
+
 BOOL ScmLockDatabaseExclusive(VOID);
 BOOL ScmLockDatabaseShared(VOID);
 VOID ScmUnlockDatabase(VOID);