From 17c7dd01446c33f878babd9b59c0d5c4f561b589 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=A9=20van=20Geldorp?= Date: Fri, 16 Sep 2005 15:34:19 +0000 Subject: [PATCH] Only access dwTypeData if the caller pronounced it valid. svn path=/trunk/; revision=17883 --- reactos/lib/user32/windows/menu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/reactos/lib/user32/windows/menu.c b/reactos/lib/user32/windows/menu.c index ca39b7df77d..14699b25c42 100644 --- a/reactos/lib/user32/windows/menu.c +++ b/reactos/lib/user32/windows/menu.c @@ -4646,7 +4646,10 @@ SetMenuItemInfoW( MENUITEMINFOW MenuItemInfoW; RtlCopyMemory(&MenuItemInfoW, lpmii, min(lpmii->cbSize, sizeof(MENUITEMINFOW))); - MenuItemInfoW.cch = wcslen(MenuItemInfoW.dwTypeData); + if (0 != (MenuItemInfoW.fMask & MIIM_STRING)) + { + MenuItemInfoW.cch = wcslen(MenuItemInfoW.dwTypeData); + } return NtUserMenuItemInfo(hMenu, uItem, fByPosition, (PROSMENUITEMINFO)&MenuItemInfoW, TRUE);