[SHELL32][SDK] Implement SHStartNetConnectionDialogA (#5847)

and add SHStartNetConnectionDialog prototype to <shlobj.h>.

dll/win32/shell32/stubs.cpp

@@ -712,22 +712,10 @@ PifMgr_SetProperties(HANDLE hHandle, LPCSTR lpName, LPCVOID lpUnknown, INT iUnkn
  */
 EXTERN_C HRESULT
 WINAPI
-SHStartNetConnectionDialogA(HWND hwnd,
+SHStartNetConnectionDialogW(
-                            LPCSTR pszRemoteName,
+    _In_ HWND hwnd,
-                            DWORD dwType)
+    _In_ LPCWSTR pszRemoteName,
-{
+    _In_ DWORD dwType)
-    FIXME("SHStartNetConnectionDialogA() stub\n");
-    return E_FAIL;
-}
-
-/*
- * Unimplemented
- */
-EXTERN_C HRESULT
-WINAPI
-SHStartNetConnectionDialogW(HWND hwnd,
-                            LPCWSTR pszRemoteName,
-                            DWORD dwType)
 {
     FIXME("SHStartNetConnectionDialogW() stub\n");
     return E_FAIL;

dll/win32/shell32/utils.cpp

@@ -604,3 +604,29 @@ Activate_RunDLL(
     GetWindowThreadProcessId(GetShellWindow(), &dwProcessID);
     return AllowSetForegroundWindow(dwProcessID);
 }
+
+/*************************************************************************
+ *                SHStartNetConnectionDialogA (SHELL32.12)
+ *
+ * @see https://learn.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-shstartnetconnectiondialoga
+ */
+EXTERN_C
+HRESULT WINAPI
+SHStartNetConnectionDialogA(
+    _In_ HWND hwnd,
+    _In_ LPCSTR pszRemoteName,
+    _In_ DWORD dwType)
+{
+    LPCWSTR pszRemoteNameW = NULL;
+    CStringW strRemoteNameW;
+
+    TRACE("(%p, %s, %lu)\n", hwnd, debugstr_a(pszRemoteName), dwType);
+
+    if (pszRemoteName)
+    {
+        strRemoteNameW = pszRemoteName;
+        pszRemoteNameW = strRemoteNameW;
+    }
+
+    return SHStartNetConnectionDialogW(hwnd, pszRemoteNameW, dwType);
+}

dll/win32/shell32/wine/shellord.c

@@ -2348,9 +2348,15 @@ BOOL WINAPI SHGetNewLinkInfoW(LPCWSTR pszLinkTo, LPCWSTR pszDir, LPWSTR pszName,
 
 HRESULT WINAPI SHStartNetConnectionDialog(HWND hwnd, LPCSTR pszRemoteName, DWORD dwType)
 {
+#ifdef __REACTOS__
+    if (SHELL_OsIsUnicode())
+        return SHStartNetConnectionDialogW(hwnd, (LPCWSTR)pszRemoteName, dwType);
+    return SHStartNetConnectionDialogA(hwnd, pszRemoteName, dwType);
+#else
     FIXME("%p, %s, 0x%08x - stub\n", hwnd, debugstr_a(pszRemoteName), dwType);
 
     return S_OK;
+#endif
 }
 /*************************************************************************
  *              SHSetLocalizedName (SHELL32.@)

sdk/include/psdk/shlobj.h

@@ -390,6 +390,18 @@ SHOpenPropSheetW(
 
 #define SHOpenPropSheet WINELIB_NAME_AW(SHOpenPropSheet)
 
+HRESULT WINAPI
+SHStartNetConnectionDialogA(
+    _In_ HWND hwnd,
+    _In_ LPCSTR pszRemoteName,
+    _In_ DWORD dwType);
+
+HRESULT WINAPI
+SHStartNetConnectionDialogW(
+    _In_ HWND hwnd,
+    _In_ LPCWSTR pszRemoteName,
+    _In_ DWORD dwType);
+
 /*****************************************************************************
  * IContextMenu interface
  */