[NTOSKRNL-CMLIB]

Continue to use the new debugging macros introduced in r58132.

svn path=/trunk/; revision=58138

reactos/lib/cmlib/hivecell.c

@@ -548,8 +548,7 @@ HvTrackCellRef(PHV_TRACK_CELL_REF CellRef,
     }
 
     /* FIXME: TODO */
-    DPRINT1("ERROR: Too many references\n");
+    ASSERTMSG(FALSE, "ERROR: Too many references\n");
-    ASSERT(FALSE); // while (TRUE);
     return FALSE;
 }
 

reactos/ntoskrnl/cache/cachesub.c

@@ -131,8 +131,7 @@ CcGetFlushedValidData(IN PSECTION_OBJECT_POINTERS SectionObjectPointer,
                       IN BOOLEAN CcInternalCaller)
 {
     LARGE_INTEGER Result = {{0}};
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return Result;
 }
 

reactos/ntoskrnl/cache/copysup.c

@@ -121,8 +121,7 @@ CcFastCopyRead(IN PFILE_OBJECT FileObject,
                OUT PVOID Buffer,
                OUT PIO_STATUS_BLOCK IoStatus)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
 }
 
 BOOLEAN
@@ -208,8 +207,7 @@ CcFastCopyWrite(IN PFILE_OBJECT FileObject,
                 IN ULONG Length,
                 IN PVOID Buffer)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
 }
 
 BOOLEAN
@@ -219,8 +217,7 @@ CcCanIWrite(IN PFILE_OBJECT FileObject,
             IN BOOLEAN Wait,
             IN UCHAR Retrying)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return FALSE;
 }
 
@@ -233,8 +230,7 @@ CcDeferWrite(IN PFILE_OBJECT FileObject,
              IN ULONG BytesToWrite,
              IN BOOLEAN Retrying)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
 }
 
 /* EOF */

reactos/ntoskrnl/cache/fssup.c

@@ -392,14 +392,13 @@ CcPurgeCacheSection(IN PSECTION_OBJECT_POINTERS SectionObjectPointer,
     CcpFlushCache(Map, NULL, 0, NULL, TRUE);
     return TRUE;
 }
-
+
 VOID
 NTAPI
 CcSetDirtyPageThreshold(IN PFILE_OBJECT FileObject,
                         IN ULONG DirtyPageThreshold)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
 }
 
 /*

reactos/ntoskrnl/cache/logsup.c

@@ -23,8 +23,7 @@ CcSetAdditionalCacheAttributes(IN PFILE_OBJECT FileObject,
                                IN BOOLEAN DisableReadAhead,
                                IN BOOLEAN DisableWriteBehind)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
 }
 
 VOID
@@ -47,17 +46,15 @@ CcGetDirtyPages(IN PVOID LogHandle,
                 IN PVOID Context2)
 {
     LARGE_INTEGER Result = {{0}};
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return Result;
 }
-
+
 BOOLEAN
 NTAPI
 CcIsThereDirtyData(IN PVPB Vpb)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return FALSE;
 }
 
@@ -67,8 +64,7 @@ CcGetLsnForFileObject(IN PFILE_OBJECT FileObject,
                       OUT OPTIONAL PLARGE_INTEGER OldestLsn)
 {
     LARGE_INTEGER Result = {{0}};
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return Result;
 }
 

reactos/ntoskrnl/include/internal/i386/ke.h

@@ -137,8 +137,7 @@ typedef union _KTRAP_EXIT_SKIP_BITS
                    IN ULONG Flags)                  \
     {                                               \
         /* Not yet handled */                       \
-        UNIMPLEMENTED;                              \
+        UNIMPLEMENTED_DBGBREAK();                   \
-        ASSERT(FALSE); /* while (TRUE); */          \
         return FALSE;                               \
     }
 

reactos/ntoskrnl/io/iomgr/irp.c

@@ -265,8 +265,7 @@ IopCompleteRequest(IN PKAPC Apc,
             (Irp->IoStatus.Information == IO_REPARSE_TAG_MOUNT_POINT))
         {
             /* We should never get this yet */
-            DPRINT1("Reparse support not yet present!\n");
+            UNIMPLEMENTED_DBGBREAK("Reparse support not yet present!\n");
-            ASSERT(FALSE); // while (TRUE);
             return;
         }
     }
@@ -1373,8 +1372,7 @@ IofCompleteRequest(IN PIRP Irp,
                              PriorityBoost);
 #else
             /* Not implemented yet. */
-            DPRINT1("Not supported!\n");
+            UNIMPLEMENTED_DBGBREAK("Not supported!\n");
-            ASSERT(FALSE); // while (TRUE);
 #endif
         }
 

reactos/ntoskrnl/io/pnpmgr/pnpmgr.c

@@ -3784,7 +3784,7 @@ PiGetDeviceRegistryProperty(IN PDEVICE_OBJECT DeviceObject,
 
 #define PIP_RETURN_DATA(x, y)   {ReturnLength = x; Data = y; Status = STATUS_SUCCESS; break;}
 #define PIP_REGISTRY_DATA(x, y) {ValueName = x; ValueType = y; break;}
-#define PIP_UNIMPLEMENTED()     {UNIMPLEMENTED; ASSERT(FALSE); /* while (TRUE); */ break;}
+#define PIP_UNIMPLEMENTED()     {UNIMPLEMENTED_DBGBREAK(); break;}
 
 /*
  * @implemented

reactos/ntoskrnl/kd64/amd64/kdx64.c

@@ -139,8 +139,7 @@ KdpSysReadBusData(IN ULONG BusDataType,
                   IN ULONG Length,
                   OUT PULONG ActualLength)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return STATUS_UNSUCCESSFUL;
 }
 
@@ -154,8 +153,7 @@ KdpSysWriteBusData(IN ULONG BusDataType,
                    IN ULONG Length,
                    OUT PULONG ActualLength)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return STATUS_UNSUCCESSFUL;
 }
 
@@ -357,8 +355,7 @@ NTSTATUS
 NTAPI
 KdpSysCheckLowMemory(IN ULONG Flags)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return STATUS_UNSUCCESSFUL;
 }
 
@@ -366,7 +363,8 @@ NTSTATUS
 NTAPI
 KdpAllowDisable(VOID)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return STATUS_ACCESS_DENIED;
 }
+
+/* EOF */

reactos/ntoskrnl/kd64/arm/kdarm.c

@@ -22,8 +22,7 @@ NTAPI
 KdpGetStateChange(IN PDBGKD_MANIPULATE_STATE64 State,
                   IN PCONTEXT Context)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
 }
 
 VOID
@@ -31,8 +30,7 @@ NTAPI
 KdpSetContextState(IN PDBGKD_ANY_WAIT_STATE_CHANGE WaitStateChange,
                    IN PCONTEXT Context)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
 }
 
 NTSTATUS
@@ -40,8 +38,7 @@ NTAPI
 KdpSysReadMsr(IN ULONG Msr,
               OUT PLARGE_INTEGER MsrValue)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return STATUS_UNSUCCESSFUL;
 }
 
@@ -50,8 +47,7 @@ NTAPI
 KdpSysWriteMsr(IN ULONG Msr,
                IN PLARGE_INTEGER MsrValue)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return STATUS_UNSUCCESSFUL;
 }
 
@@ -65,8 +61,7 @@ KdpSysReadBusData(IN ULONG BusDataType,
                   IN ULONG Length,
                   OUT PULONG ActualLength)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return STATUS_UNSUCCESSFUL;
 }
 
@@ -80,8 +75,7 @@ KdpSysWriteBusData(IN ULONG BusDataType,
                    IN ULONG Length,
                    OUT PULONG ActualLength)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return STATUS_UNSUCCESSFUL;
 }
 
@@ -93,8 +87,7 @@ KdpSysReadControlSpace(IN ULONG Processor,
                        IN ULONG Length,
                        OUT PULONG ActualLength)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return STATUS_UNSUCCESSFUL;
 }
 
@@ -106,8 +99,7 @@ KdpSysWriteControlSpace(IN ULONG Processor,
                         IN ULONG Length,
                         OUT PULONG ActualLength)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return STATUS_UNSUCCESSFUL;
 }
 
@@ -121,8 +113,7 @@ KdpSysReadIoSpace(IN ULONG InterfaceType,
                   IN ULONG DataSize,
                   OUT PULONG ActualDataSize)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return STATUS_UNSUCCESSFUL;
 }
 
@@ -136,8 +127,7 @@ KdpSysWriteIoSpace(IN ULONG InterfaceType,
                    IN ULONG DataSize,
                    OUT PULONG ActualDataSize)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return STATUS_UNSUCCESSFUL;
 }
 
@@ -145,8 +135,7 @@ NTSTATUS
 NTAPI
 KdpSysCheckLowMemory(IN ULONG Flags)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return STATUS_UNSUCCESSFUL;
 }
 
@@ -154,7 +143,6 @@ NTSTATUS
 NTAPI
 KdpAllowDisable(VOID)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return STATUS_ACCESS_DENIED;
 }

reactos/ntoskrnl/ke/dpc.c

@@ -779,9 +779,7 @@ KeInsertQueueDpc(IN PKDPC Dpc,
             if (!(Prcb->DpcThreadActive) && !(Prcb->DpcThreadRequested))
             {
                 /* FIXME: Setup Threaded DPC */
-                DPRINT1("Threaded DPC not supported\n");
+                UNIMPLEMENTED_FATAL("Threaded DPC not supported\n");
-                ASSERT(FALSE);
-                while (TRUE);
             }
         }
         else

reactos/ntoskrnl/ke/i386/context.c

@@ -35,8 +35,7 @@ KiSwapProcess(IN PKPROCESS NewProcess,
     if (NewProcess->LdtDescriptor.LimitLow != OldProcess->LdtDescriptor.LimitLow)
     {
         /* Not handled yet */
-        UNIMPLEMENTED;
+        UNIMPLEMENTED_DBGBREAK();
-        ASSERT(FALSE); // while (TRUE);
         return;
     }
     

reactos/ntoskrnl/ke/i386/traphdlr.c

@@ -662,9 +662,7 @@ KiTrap06Handler(IN PKTRAP_FRAME TrapFrame)
         if (!VdmDispatchBop(TrapFrame))
         {
             /* Should only happen in VDM mode */
-            UNIMPLEMENTED;
+            UNIMPLEMENTED_FATAL();
-            ASSERT(FALSE);
-            while (TRUE);
         }
         
         /* Bring IRQL back */
@@ -735,9 +733,7 @@ KiTrap07Handler(IN PKTRAP_FRAME TrapFrame)
         if (SaveArea->Cr0NpxState & CR0_EM)
         {
             /* Not implemented */
-            UNIMPLEMENTED;
+            UNIMPLEMENTED_FATAL();
-            ASSERT(FALSE);
-            while (TRUE);
         }
     
         /* Save CR0 and check NPX state */
@@ -922,9 +918,7 @@ KiTrap0DHandler(IN PKTRAP_FRAME TrapFrame)
         if (__builtin_expect(Ki386HandleOpcodeV86(TrapFrame) == 0xFF, 0))
         {
             /* Should only happen in VDM mode */
-            UNIMPLEMENTED;
+            UNIMPLEMENTED_FATAL();
-            ASSERT(FALSE);
-            while (TRUE);
         }
         
         /* Bring IRQL back */
@@ -1079,9 +1073,7 @@ KiTrap0DHandler(IN PKTRAP_FRAME TrapFrame)
         ((PVOID)TrapFrame->Eip < (PVOID)KiTrap0DHandler))
     {
         /* Not implemented */
-        UNIMPLEMENTED;
+        UNIMPLEMENTED_FATAL();
-        ASSERT(FALSE);
-        while (TRUE);
     }
 
     /*
@@ -1136,9 +1128,7 @@ KiTrap0DHandler(IN PKTRAP_FRAME TrapFrame)
         else
         {
             /* Otherwise, this is another kind of IRET fault */
-            UNIMPLEMENTED;
+            UNIMPLEMENTED_FATAL();
-            ASSERT(FALSE);
-            while (TRUE);
         }
     }
      
@@ -1195,9 +1185,7 @@ KiTrap0EHandler(IN PKTRAP_FRAME TrapFrame)
             FIELD_OFFSET(KTRAP_FRAME, EFlags))
         {
             /* The stack is somewhere in between frames, we need to fix it */
-            UNIMPLEMENTED;
+            UNIMPLEMENTED_FATAL();
-            ASSERT(FALSE);
-            while (TRUE);
         }
     }
 
@@ -1261,9 +1249,7 @@ KiTrap0EHandler(IN PKTRAP_FRAME TrapFrame)
         (TrapFrame->Eip == (ULONG_PTR)ReadBatch))
     {
         /* Not yet implemented */
-        UNIMPLEMENTED;
+        UNIMPLEMENTED_FATAL();
-        ASSERT(FALSE);
-        while (TRUE);
     }
 #endif
     /* Check for VDM trap */
@@ -1445,16 +1431,14 @@ VOID
 FASTCALL
 KiGetTickCountHandler(IN PKTRAP_FRAME TrapFrame)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
 }
 
 VOID
 FASTCALL
 KiCallbackReturnHandler(IN PKTRAP_FRAME TrapFrame)
 {
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
 }
 
 DECLSPEC_NORETURN
@@ -1624,9 +1608,7 @@ KiSystemCall(IN PKTRAP_FRAME TrapFrame,
     if (__builtin_expect((Arguments < (PVOID)MmUserProbeAddress) && !(KiUserTrap(TrapFrame)), 0))
     {
         /* Access violation */
-        UNIMPLEMENTED;
+        UNIMPLEMENTED_FATAL();
-        ASSERT(FALSE);
-        while (TRUE);
     }
     
     /* Call pre-service debug hook */
@@ -1690,9 +1672,7 @@ NTAPI
 Kei386EoiHelper(VOID)
 {
     /* We should never see this call happening */
-    DPRINT1("Mismatched NT/HAL version");
+    ERROR_FATAL("Mismatched NT/HAL version");
-    ASSERT(FALSE);
-    while (TRUE);
 }
 
 /* EOF */

reactos/ntoskrnl/mm/arm/stubs.c

@@ -374,8 +374,7 @@ Mmi386ReleaseMmInfo(IN PEPROCESS Process)
     //
     // FIXME-USER: Need to delete address space
     //
-    UNIMPLEMENTED;
+    UNIMPLEMENTED_DBGBREAK();
-    ASSERT(FALSE); // while (TRUE);
     return STATUS_NOT_IMPLEMENTED;
 }
 

reactos/ntoskrnl/po/povolume.c

@@ -299,10 +299,7 @@ PopFlushVolumes(IN BOOLEAN ShuttingDown)
     if (!(FlushPolicy & 2))
     {
         /* ReactOS only implements this routine for shutdown, which requires it */
-        UNIMPLEMENTED;
+        UNIMPLEMENTED_DBGBREAK();
-        ASSERT(FALSE); // while (TRUE);
-        KeReleaseGuardedMutex(&PopVolumeLock);
-        return;
     }
 
     /* Check if there were no volumes at all */