Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-06-28 17:01:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

[NOTEPAD] Simplify GetSelectionText (#5083)

Browse source 
Use EM_GETHANDLE message to get text. CORE-18837
This commit is contained in:
Katayama Hirofumi MZ 2023-02-20 22:00:49 +09:00 committed by GitHub
parent f7f2ed201a
commit 0cd80c17f6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 40 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
base/applications/notepad/dialog.c
View file

@ -242,68 +242,41 @@ BOOL HasFileExtension(LPCTSTR szFilename)
int GetSelectionTextLength(HWND hWnd) int GetSelectionTextLength(HWND hWnd)
{ {
DWORD dwStart = 0; DWORD dwStart = 0, dwEnd = 0;
DWORD dwEnd = 0;
SendMessage(hWnd, EM_GETSEL, (WPARAM)&dwStart, (LPARAM)&dwEnd); SendMessage(hWnd, EM_GETSEL, (WPARAM)&dwStart, (LPARAM)&dwEnd);
return dwEnd - dwStart; return dwEnd - dwStart;
} }
int GetSelectionText(HWND hWnd, LPTSTR lpString, int nMaxCount) int GetSelectionText(HWND hWnd, LPTSTR lpString, int nMaxCount)
{ {
DWORD dwStart = 0; DWORD dwStart = 0, dwEnd = 0;
DWORD dwEnd = 0; INT cchText = GetWindowTextLength(hWnd);
DWORD dwSize; LPTSTR pszText;
HRESULT hResult; HLOCAL hLocal;
LPTSTR lpTemp; HRESULT hr;
if (!lpString)
{
return 0;
}
SendMessage(hWnd, EM_GETSEL, (WPARAM)&dwStart, (LPARAM)&dwEnd); SendMessage(hWnd, EM_GETSEL, (WPARAM)&dwStart, (LPARAM)&dwEnd);
if (!lpString || dwStart == dwEnd || cchText == 0)
if (dwStart == dwEnd)
{
return 0; return 0;
}
dwSize = GetWindowTextLength(hWnd) + 1; hLocal = (HLOCAL)SendMessage(hWnd, EM_GETHANDLE, 0, 0);
lpTemp = HeapAlloc(GetProcessHeap(), 0, dwSize * sizeof(TCHAR)); pszText = (LPTSTR)LocalLock(hLocal);
if (!lpTemp) if (!pszText)
{
return 0; return 0;
}
dwSize = GetWindowText(hWnd, lpTemp, dwSize); hr = StringCchCopyN(lpString, nMaxCount, pszText + dwStart, dwEnd - dwStart);
LocalUnlock(hLocal);
if (!dwSize) switch (hr)
{
HeapFree(GetProcessHeap(), 0, lpTemp);
return 0;
}
hResult = StringCchCopyN(lpString, nMaxCount, lpTemp + dwStart, dwEnd - dwStart);
HeapFree(GetProcessHeap(), 0, lpTemp);
switch (hResult)
{ {
case S_OK: case S_OK:
{
return dwEnd - dwStart; return dwEnd - dwStart;
}
case STRSAFE_E_INSUFFICIENT_BUFFER: case STRSAFE_E_INSUFFICIENT_BUFFER:
{
return nMaxCount - 1; return nMaxCount - 1;
}
default: default:
{
return 0; return 0;
}
} }
} }