From 0b74f9e65ebe95cebd26092c89324393d8829323 Mon Sep 17 00:00:00 2001 From: Christoph von Wittich Date: Thu, 3 Sep 2015 09:33:58 +0000 Subject: [PATCH] [OSK] fix resource leak in error case CID 1322148 svn path=/trunk/; revision=68931 --- reactos/base/applications/osk/main.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/reactos/base/applications/osk/main.c b/reactos/base/applications/osk/main.c index 2ea315645e7..9932f7937a2 100644 --- a/reactos/base/applications/osk/main.c +++ b/reactos/base/applications/osk/main.c @@ -40,10 +40,15 @@ int OSK_SetImage(int IdDlgItem, int IdResource) hIcon = (HICON)LoadImage(Globals.hInstance, MAKEINTRESOURCE(IdResource), IMAGE_ICON, 16, 16, LR_DEFAULTCOLOR); - if (hIcon == NULL) return FALSE; + if (hIcon == NULL) + return FALSE; hWndItem = GetDlgItem(Globals.hMainWnd, IdDlgItem); - if (hWndItem == NULL) return FALSE; + if (hWndItem == NULL) + { + DestroyIcon(hIcon); + return FALSE; + } SendMessage(hWndItem, BM_SETIMAGE, (WPARAM)IMAGE_ICON, (LPARAM)hIcon);