Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-24 09:25:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NTOS]: Fix a potential memory leak.

Browse source 
- If one of the ZwSetValueKey function fails, 'Node->ServiceName.Buffer' is leaked. 
- Also use 'L' prefix for wide characters.
Patch by Lesan Ilie, thanks!
- Use "P(C)WSTR" instead of win32 "LP(C)WSTR" string pointer types (by me).
CORE-13207 #resolve

svn path=/trunk/; revision=74491
This commit is contained in:
Hermès Bélusca-Maïto 2017-05-07 17:50:18 +00:00
parent cf595e72fa
commit 0b299f6798
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
reactos/ntoskrnl/io/pnpmgr/pnpmgr.c
View file

@ -1144,6 +1144,7 @@ IopCreateDeviceNode(PDEVICE_NODE ParentNode,
if (!NT_SUCCESS(Status))
{
ExFreePool(Node->ServiceName.Buffer);
ExFreePoolWithTag(Node, TAG_IO_DEVNODE);
return Status;
}
@ -1437,7 +1438,7 @@ IopCreateDeviceKeyPath(IN PCUNICODE_STRING RegistryPath,
HANDLE hParent = NULL, hKey;
OBJECT_ATTRIBUTES ObjectAttributes;
UNICODE_STRING KeyName;
LPCWSTR Current, Last;
PCWSTR Current, Last;
USHORT Length;
NTSTATUS Status;
@ -1462,7 +1463,7 @@ IopCreateDeviceKeyPath(IN PCUNICODE_STRING RegistryPath,
/* Go up to the end of the string */
while (Current <= Last)
{
if (Current != Last && *Current != '\\')
if (Current != Last && *Current != L'\\')
{
/* Not the end of the string and not a separator */
Current++;
@ -1510,7 +1511,7 @@ IopCreateDeviceKeyPath(IN PCUNICODE_STRING RegistryPath,
/* Start with this new parent key */
hParent = hKey;
Current++;
KeyName.Buffer = (LPWSTR)Current;
KeyName.Buffer = (PWSTR)Current;
}
return STATUS_UNSUCCESSFUL;
@ -4258,7 +4259,7 @@ IoOpenDeviceRegistryKey(IN PDEVICE_OBJECT DeviceObject,
static WCHAR EnumKeyName[] = L"Enum\\";
static WCHAR DeviceParametersKeyName[] = L"Device Parameters";
ULONG KeyNameLength;
LPWSTR KeyNameBuffer;
PWSTR KeyNameBuffer;
UNICODE_STRING KeyName;
ULONG DriverKeyLength;
OBJECT_ATTRIBUTES ObjectAttributes;