Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-06-29 17:31:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not hold the PiThreadListLock spinlock while calling KeDispatchObjectWait() because the latter will acquire the spinlock.

Browse source 
This fixes bug #31.

svn path=/trunk/; revision=6505
This commit is contained in:
Eric Kohl 2003-11-02 03:09:06 +00:00
parent fc75de898d
commit 08c981ba53
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
reactos/ntoskrnl/ps/kill.c
View file

@ -1,4 +1,4 @@
/* $Id: kill.c,v 1.66 2003/11/02 01:16:21 ekohl Exp $
/* $Id: kill.c,v 1.67 2003/11/02 03:09:06 ekohl Exp $
*
* COPYRIGHT: See COPYING in the top level directory
* PROJECT: ReactOS kernel
@ -158,18 +158,17 @@ PsTerminateCurrentThread(NTSTATUS ExitStatus)
PKTHREAD Thread;
PLIST_ENTRY current_entry;
PKMUTANT Mutant;
DPRINT("terminating %x\n",CurrentThread);
KeAcquireSpinLock(&PiThreadListLock, &oldIrql);
CurrentThread = PsGetCurrentThread();
DPRINT("terminating %x\n",CurrentThread);
CurrentThread->ExitStatus = ExitStatus;
Thread = KeGetCurrentThread();
KeCancelTimer(&Thread->Timer);
KeReleaseSpinLock(&PiThreadListLock, oldIrql);
/* abandon all owned mutants */
current_entry = Thread->MutantListHead.Flink;
while (current_entry != &Thread->MutantListHead)
@ -183,12 +182,12 @@ PsTerminateCurrentThread(NTSTATUS ExitStatus)
current_entry = Thread->MutantListHead.Flink;
}
KeAcquireSpinLock(&PiThreadListLock, &oldIrql);
KeAcquireDispatcherDatabaseLockAtDpcLevel();
oldIrql = KeAcquireDispatcherDatabaseLock();
CurrentThread->Tcb.DispatcherHeader.SignalState = TRUE;
KeDispatcherObjectWake(&CurrentThread->Tcb.DispatcherHeader);
KeReleaseDispatcherDatabaseLockFromDpcLevel ();
KeReleaseDispatcherDatabaseLock (oldIrql);
KeAcquireSpinLock(&PiThreadListLock, &oldIrql);
ExpSwapThreadEventPair(CurrentThread, NULL); /* Release the associated eventpair object, if there was one */
KeRemoveAllWaitsThread (CurrentThread, STATUS_UNSUCCESSFUL, FALSE);