From 07f2fe8cb5337ba2e5cf51bf8b00442ba02e9510 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Herm=C3=A8s=20B=C3=A9lusca-Ma=C3=AFto?= Date: Wed, 23 Dec 2015 16:15:08 +0000 Subject: [PATCH] [XDK] Correctly fix the definition of DRIVER_FS_NOTIFICATION (done the same way as the other DRIVER_xxx "callback" functions; by the way you'll notice they are all NTAPI aka. __stdcall. This is not explicitely mentioned in the W(D)DK, because MS supposes you compile all your kernel-mode code in stdcall convention, the WDK environment coming with preset default compiler switches enabling that. But if you try changing them, you'll run into big troubles. In our headers on the contrary we explicitely mention the calling conventions). [FLTMGR] Fix FltpFsNotification to adhere to the correct DRIVER_FS_NOTIFICATION definition. Addendum to r70410. svn path=/trunk/; revision=70413 --- reactos/drivers/fs_minifilter/fltmgr/Interface.c | 2 ++ reactos/include/xdk/iotypes.h | 16 +++++----------- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/reactos/drivers/fs_minifilter/fltmgr/Interface.c b/reactos/drivers/fs_minifilter/fltmgr/Interface.c index ef191936cdf..fe75d8effd6 100644 --- a/reactos/drivers/fs_minifilter/fltmgr/Interface.c +++ b/reactos/drivers/fs_minifilter/fltmgr/Interface.c @@ -66,6 +66,7 @@ FltpDetachFromFileSystemDevice( DRIVER_FS_NOTIFICATION FltpFsNotification; VOID +NTAPI FltpFsNotification( _In_ PDEVICE_OBJECT DeviceObject, _In_ BOOLEAN FsActive @@ -586,6 +587,7 @@ FltpDetachFromFileSystemDevice(_In_ PDEVICE_OBJECT DeviceObject) DRIVER_FS_NOTIFICATION FltpFsNotification; VOID +NTAPI FltpFsNotification(_In_ PDEVICE_OBJECT DeviceObject, _In_ BOOLEAN FsActive) { diff --git a/reactos/include/xdk/iotypes.h b/reactos/include/xdk/iotypes.h index b31514b2754..20aaa549d2d 100644 --- a/reactos/include/xdk/iotypes.h +++ b/reactos/include/xdk/iotypes.h @@ -6939,17 +6939,11 @@ typedef struct _REMOTE_LINK_TRACKING_INFORMATION { #define IO_STOP_ON_SYMLINK 0x0008 #define IO_MM_PAGING_FILE 0x0010 -//typedef VOID -//( *PDRIVER_FS_NOTIFICATION) ( -// _In_ PDEVICE_OBJECT DeviceObject, -// _In_ BOOLEAN FsActive); - -typedef -VOID -DRIVER_FS_NOTIFICATION( - _In_ PDEVICE_OBJECT DeviceObject, - _In_ BOOLEAN FsActive -); +_Function_class_(DRIVER_FS_NOTIFICATION) +typedef VOID +(NTAPI DRIVER_FS_NOTIFICATION)( + _In_ PDEVICE_OBJECT DeviceObject, + _In_ BOOLEAN FsActive); typedef DRIVER_FS_NOTIFICATION *PDRIVER_FS_NOTIFICATION; typedef enum _FS_FILTER_SECTION_SYNC_TYPE {