[USETUP] Display the chosen filesystem name in case of bootcode installation failure.

Simplified implementation of the proposed solution by George Bișoc
and revised by Victor Perevertkin from PR #952.

NOTE: For whatever reason ERROR_INSTALL_BOOTCODE and ERROR_WRITE_BOOT
seem to be redundant with each other. To be investigated...
This commit is contained in:
Hermès Bélusca-Maïto 2018-11-08 00:54:59 +01:00
parent 4c6370de16
commit 073c09e491
No known key found for this signature in database
GPG key ID: 3B2539C65E7B93D0
26 changed files with 57 additions and 53 deletions

View file

@ -1479,7 +1479,7 @@ MUI_ERROR bgBGErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"<EFBFBD>¥γα―¥θ­® α« £ ­¥ ­  ®§­ η Ά θ § ―¨α (bootcode) §  FAT Ά α¨α⥬­¨ο ¤ο«.",
"<EFBFBD>¥γα―¥θ­® α« £ ­¥ ­  ®§­ η Ά θ § ―¨α (bootcode) §  %S Ά α¨α⥬­¨ο ¤ο«.",
"ENTER = <20>१ ¯ã᪠­¥ ­  ª®¬¯îâêà "
},
{
@ -1531,7 +1531,7 @@ MUI_ERROR bgBGErrorEntries[] =
{
// ERROR_INSTALL_BOOTCODE,
//"Setup failed to install the FAT bootcode on the system partition.",
"<EFBFBD>¥γα―¥θ­® α« £ ­¥ ­  ®΅γΆ ι¨ο <20>®¤ §  FAT ­  α¨α⥬­¨ο ¤ο«.",
"<EFBFBD>¥γα―¥θ­® α« £ ­¥ ­  ®΅γΆ ι¨ο <20>®¤ §  %S ­  α¨α⥬­¨ο ¤ο«.",
"ENTER = <20>१ ¯ã᪠­¥ ­  ª®¬¯îâêà "
},
{

View file

@ -1471,7 +1471,7 @@ MUI_ERROR bnBDErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Setup failed to install FAT bootcode on the system partition.",
"Setup failed to install %S bootcode on the system partition.",
"ENTER = Reboot computer"
},
{
@ -1522,7 +1522,7 @@ MUI_ERROR bnBDErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Setup failed to install the FAT bootcode on the system partition.",
"Setup failed to install the %S bootcode on the system partition.",
"ENTER = Reboot computer"
},
{

View file

@ -1477,7 +1477,7 @@ MUI_ERROR csCZErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Nepodaýilo se nainstalovat FAT zavadŘź na systmově oddˇl.",
"Nepodaýilo se nainstalovat %S zavadŘź na systmově oddˇl.",
"ENTER = Restartovat poŸ¡taŸ"
},
{
@ -1528,7 +1528,7 @@ MUI_ERROR csCZErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Nepodaýilo se nainstalovat FAT zavadŘź na systmově oddˇl.",
"Nepodaýilo se nainstalovat %S zavadŘź na systmově oddˇl.",
"ENTER = Restartovat poŸ¡taŸ"
},
{

View file

@ -1484,7 +1484,7 @@ MUI_ERROR daDKErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Installationen kunne ikke installere FAT-startkode p† systempartitionen.",
"Installationen kunne ikke installere %S-startkode p† systempartitionen.",
"ENTER = Genstart"
},
{
@ -1535,7 +1535,7 @@ MUI_ERROR daDKErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Installationen kunne ikke installere FAT-startkode p† systempartitionen.",
"Installationen kunne ikke installere %S-startkode p† systempartitionen.",
"ENTER = Genstart"
},
{

View file

@ -1471,7 +1471,7 @@ MUI_ERROR deDEErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Der FAT-Bootcode konnte nicht auf der Partition installiert werden.",
"Der %S-Bootcode konnte nicht auf der Partition installiert werden.",
"EINGABETASTE = Computer neu starten"
},
{
@ -1522,7 +1522,7 @@ MUI_ERROR deDEErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Der FAT-Bootcode konnte nicht auf der Partition installiert werden.",
"Der %S-Bootcode konnte nicht auf der Partition installiert werden.",
"EINGABETASTE = Computer neu starten"
},
{

View file

@ -1495,7 +1495,7 @@ MUI_ERROR elGRErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Setup failed to install FAT bootcode on the system partition.",
"Setup failed to install %S bootcode on the system partition.",
"ENTER = „§˜¤œ¡¡å¤ž©ž ¬§¦¢¦š ©«ã"
},
{
@ -1546,7 +1546,7 @@ MUI_ERROR elGRErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Setup failed to install the FAT bootcode on the system partition.",
"Setup failed to install the %S bootcode on the system partition.",
"ENTER = „§˜¤œ¡¡å¤ž©ž ¬§¦¢¦š ©«ã"
},
{

View file

@ -1472,7 +1472,7 @@ MUI_ERROR enUSErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Setup failed to install FAT bootcode on the system partition.",
"Setup failed to install %S bootcode on the system partition.",
"ENTER = Reboot computer"
},
{
@ -1523,7 +1523,7 @@ MUI_ERROR enUSErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Setup failed to install the FAT bootcode on the system partition.",
"Setup failed to install the %S bootcode on the system partition.",
"ENTER = Reboot computer"
},
{

View file

@ -1474,7 +1474,7 @@ MUI_ERROR esESErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"El instalador fall¢ al instalar el c¢digo de inicio FAT en la partici¢n del sistema.",
"El instalador fall¢ al instalar el c¢digo de inicio %S en la partici¢n del sistema.",
"INTRO = Reiniciar el equipo"
},
{
@ -1525,7 +1525,7 @@ MUI_ERROR esESErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"El instalador fall¢ al instalar el c¢digo de inicio FAT en la partici¢n del sistema.",
"El instalador fall¢ al instalar el c¢digo de inicio %S en la partici¢n del sistema.",
"INTRO = Reiniciar el equipo"
},
{

View file

@ -1472,7 +1472,7 @@ MUI_ERROR etEEErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"S<EFBFBD>steemikettale ei ännestunud kirjutada FAT alglaadimiskoodi.",
"S<EFBFBD>steemikettale ei ännestunud kirjutada %S alglaadimiskoodi.",
"ENTER = Taask„ivita arvuti"
},
{
@ -1523,7 +1523,7 @@ MUI_ERROR etEEErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"S<EFBFBD>steemikettale ei ännestunud paigaldada FAT alglaadimiskoodi.",
"S<EFBFBD>steemikettale ei ännestunud paigaldada %S alglaadimiskoodi.",
"ENTER = Taask„ivita arvuti"
},
{

View file

@ -1489,7 +1489,7 @@ MUI_ERROR frFRErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Echec de l'installation du code de dmarrage FAT sur la partition systŠme.",
"Echec de l'installation du code de dmarrage %S sur la partition systŠme.",
"ENTR<EFBFBD>E = Redmarrer l'ordinateur"
},
{
@ -1540,7 +1540,7 @@ MUI_ERROR frFRErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Echec de l'installation du code de dmarrage FAT sur la partition systŠme.",
"Echec de l'installation du code de dmarrage %S sur la partition systŠme.",
"ENTR<EFBFBD>E = Redmarrer l'ordinateur"
},
{

View file

@ -1471,7 +1471,7 @@ MUI_ERROR heILErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Setup failed to install FAT bootcode on the system partition.",
"Setup failed to install %S bootcode on the system partition.",
"ENTER = Reboot computer"
},
{
@ -1522,7 +1522,7 @@ MUI_ERROR heILErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Setup failed to install the FAT bootcode on the system partition.",
"Setup failed to install the %S bootcode on the system partition.",
"ENTER = Reboot computer"
},
{

View file

@ -1477,7 +1477,7 @@ MUI_ERROR itITErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Impossibile installare il bootcode FAT nella partizione di sistema.",
"Impossibile installare il bootcode %S nella partizione di sistema.",
"INVIO = Riavviare il computer"
},
{
@ -1528,7 +1528,7 @@ MUI_ERROR itITErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Impossibile installare il bootcode FAT nella partizione di sistema.",
"Impossibile installare il bootcode %S nella partizione di sistema.",
"INVIO = Riavviare il computer"
},
{

View file

@ -1472,7 +1472,7 @@ MUI_ERROR jaJPErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"セットアップハ システム パーティション ジョウヘノ FAT ブートコードノ インストールニ シッパイ シマシタ。",
"セットアップハ システム パーティション ジョウヘノ %S ブートコードノ インストールニ シッパイ シマシタ。",
"ENTER = ºÝËß­°ÀÉ »²·ÄÞ³"
},
{
@ -1523,7 +1523,7 @@ MUI_ERROR jaJPErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"セットアップハ システム パーティション ジョウヘノ FAT ブート レコード ノ インストールニ シッパイ シマシタ。",
"セットアップハ システム パーティション ジョウヘノ %S ブート レコード ノ インストールニ シッパイ シマシタ。",
"ENTER = ºÝËß­°ÀÉ »²·ÄÞ³"
},
{

View file

@ -1480,7 +1480,7 @@ MUI_ERROR ltLTErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Setup failed to install FAT bootcode on the system partition.",
"Setup failed to install %S bootcode on the system partition.",
"ENTER = Reboot computer"
},
{
@ -1531,7 +1531,7 @@ MUI_ERROR ltLTErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Setup failed to install the FAT bootcode on the system partition.",
"Setup failed to install the %S bootcode on the system partition.",
"ENTER = Reboot computer"
},
{

View file

@ -1371,7 +1371,7 @@ MUI_ERROR msMYErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Persediaan gagal memasang bootcode FAT pada partition sistem.",
"Persediaan gagal memasang bootcode %S pada partition sistem.",
"ENTER = Memulakan semula komputer"
},
{
@ -1422,7 +1422,7 @@ MUI_ERROR msMYErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Persediaan gagal memasang bootcode FAT pada partition sistem.",
"Persediaan gagal memasang bootcode %S pada partition sistem.",
"ENTER = Memulakan semula komputer"
},
{

View file

@ -1493,7 +1493,7 @@ MUI_ERROR nlNLErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Setup kan de FAT bootcode op de systeempartitie niet installeren.",
"Setup kan de %S bootcode op de systeempartitie niet installeren.",
"ENTER = Computer opnieuw opstarten"
},
{
@ -1545,7 +1545,7 @@ MUI_ERROR nlNLErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Setup kan de FAT bootcode op de systeempartitie niet installeren.",
"Setup kan de %S bootcode op de systeempartitie niet installeren.",
"ENTER = Computer opnieuw opstarten"
},
{

View file

@ -1480,7 +1480,7 @@ MUI_ERROR plPLErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Nieudane zapisanie FAT bootcode na partycji systemowej.",
"Nieudane zapisanie %S bootcode na partycji systemowej.",
"ENTER = Restart komputera"
},
{
@ -1531,7 +1531,7 @@ MUI_ERROR plPLErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Nieudana instalacja FAT bootcode na partycji systemowej.",
"Nieudana instalacja %S bootcode na partycji systemowej.",
"ENTER = Restart komputera"
},
{

View file

@ -1502,7 +1502,7 @@ MUI_ERROR ptBRErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Erro ao escrever o c¢digo de inicializa‡Æo na parti‡Æo do sistema.\n",
"Erro ao escrever o c¢digo de inicializa‡Æo %S na parti‡Æo do sistema.\n",
"ENTER=Reiniciar"
},
{
@ -1553,7 +1553,7 @@ MUI_ERROR ptBRErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Erro ao instalar o c¢digo de inicializa‡Æo na parti‡Æo do sistema.",
"Erro ao instalar o c¢digo de inicializa‡Æo %S na parti‡Æo do sistema.",
"ENTER=Reiniciar"
},
{

View file

@ -1504,7 +1504,7 @@ MUI_ERROR roROErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Eşec la instalarea codului FAT de iniţializare\n"
"Eşec la instalarea codului %S de iniţializare\n"
"pe partiþia de sistem.",
"ENTER = Repornire calculator"
},
@ -1562,7 +1562,7 @@ MUI_ERROR roROErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Eşec la instalarea codului FAT de iniţializare\n"
"Eşec la instalarea codului %S de iniţializare\n"
"pe partiþia de sistem.",
"ENTER = Repornire calculator"
},

View file

@ -1471,7 +1471,7 @@ MUI_ERROR ruRUErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"<EFBFBD>¥ γ¤ «®αμ γαβ ­®Ά¨βμ § £ΰγ§η¨<CEB7> FAT ­  α¨α⥬­λ© ΰ §¤¥«.",
"<EFBFBD>¥ γ¤ «®αμ γαβ ­®Ά¨βμ § £ΰγ§η¨<CEB7> %S ­  α¨α⥬­λ© ΰ §¤¥«.",
"ENTER = <20><EFBFBD><E382A7><EFBFBD><E7A491>"
},
{
@ -1522,7 +1522,7 @@ MUI_ERROR ruRUErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"<EFBFBD>¥ γ¤ «®αμ γαβ ­®Ά¨βμ § £ΰγ§η¨<CEB7> FAT ­  α¨α⥬­λ© ΰ §¤¥«.",
"<EFBFBD>¥ γ¤ «®αμ γαβ ­®Ά¨βμ § £ΰγ§η¨<CEB7> %S ­  α¨α⥬­λ© ΰ §¤¥«.",
"ENTER = <20><EFBFBD><E382A7><EFBFBD><E7A491>"
},
{

View file

@ -1478,7 +1478,7 @@ MUI_ERROR skSKErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Inçtal toru sa nepodarilo nainçtalovaś zav dzacˇ k˘d sŁborovho\n"
"Inçtal toru sa nepodarilo nainçtalovaś %S zav dzacˇ k˘d sŁborovho\n"
"systmu FAT na systmov£ part¡ciu.",
"ENTER = Reçtart poŸ¡taŸa"
},
@ -1531,7 +1531,7 @@ MUI_ERROR skSKErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Inçtal toru sa nepodarilo nainçtalovaś zav dzacˇ k˘d sŁborovho\n"
"Inçtal toru sa nepodarilo nainçtalovaś %S zav dzacˇ k˘d sŁborovho\n"
"systmu FAT na systmov£ part¡ciu.",
"ENTER = Reçtart poŸ¡taŸa"
},

View file

@ -1476,7 +1476,7 @@ MUI_ERROR sqALErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Instalimi deshtoj n‰ instalimin e FAT bootcode n‰ particionin e sistemit.",
"Instalimi deshtoj n‰ instalimin e %S bootcode n‰ particionin e sistemit.",
"ENTER = Ristarto kompjuterin"
},
{
@ -1527,7 +1527,7 @@ MUI_ERROR sqALErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Instalimi d‰shtoj n‰ instalimin e FAT bootcode n‰ particionin e sistemit.",
"Instalimi d‰shtoj n‰ instalimin e %S bootcode n‰ particionin e sistemit.",
"ENTER = Ristarto kompjuterin"
},
{

View file

@ -1478,7 +1478,7 @@ MUI_ERROR svSEErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Setup misslyckades installera FAT bootkod p† systempartitionen.",
"Setup misslyckades installera %S bootkod p† systempartitionen.",
"ENTER = Starta om datorn"
},
{
@ -1529,7 +1529,7 @@ MUI_ERROR svSEErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Setup misslyckades att installera FAT bootkoden p† systempartitionen.",
"Setup misslyckades att installera %S bootkoden p† systempartitionen.",
"ENTER = Starta om datorn"
},
{

View file

@ -1450,7 +1450,7 @@ MUI_ERROR trTRErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"Kur, dizge b”l<E2809D>m<EFBFBD>ne FAT ”n y<>kleme kodunu kuramad<61>.",
"Kur, dizge b”l<E2809D>m<EFBFBD>ne %S ”n y<>kleme kodunu kuramad<61>.",
"GiriŸ = Bilgisayar<61> Yeniden BaŸlat"
},
{
@ -1501,7 +1501,7 @@ MUI_ERROR trTRErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"Kur, dizge b”l<E2809D>m<EFBFBD> <20>zerinde FAT ”n y<>kleme kodunu kurmada baŸar<61>s<EFBFBD>z oldu.",
"Kur, dizge b”l<E2809D>m<EFBFBD> <20>zerinde %S ”n y<>kleme kodunu kurmada baŸar<61>s<EFBFBD>z oldu.",
"GiriŸ = Bilgisayar<61> Yeniden BaŸlat"
},
{

View file

@ -1478,7 +1478,7 @@ MUI_ERROR ukUAErrorEntries[] =
},
{
// ERROR_WRITE_BOOT,
"<EFBFBD>¥ ¢¤ «®áì ¢áâ ­®¢¨â¨ § ¢ ­â ¦ã¢ «ì­¨© ª®¤ FAT ­  á¨â¥¬­¨© ஧¤i«.",
"<EFBFBD>¥ ¢¤ «®áì ¢áâ ­®¢¨â¨ § ¢ ­â ¦ã¢ «ì­¨© ª®¤ %S ­  á¨â¥¬­¨© ஧¤i«.",
"ENTER = <20>¥à¥§ ¢ ­â ¦¨â¨ ª®¬¯'îâ¥à"
},
{
@ -1529,7 +1529,7 @@ MUI_ERROR ukUAErrorEntries[] =
},
{
// ERROR_INSTALL_BOOTCODE,
"<EFBFBD>¥ ¢¤ «®áì ¢áâ ­®¢¨â¨ § ¢ ­â ¦ã¢ «ì­¨© ª®¤ FAT ­  á¨â¥¬­¨© ஧¤i«.",
"<EFBFBD>¥ ¢¤ «®áì ¢áâ ­®¢¨â¨ § ¢ ­â ¦ã¢ «ì­¨© ª®¤ %S ­  á¨â¥¬­¨© ஧¤i«.",
"ENTER = <20>¥à¥§ ¢ ­â ¦¨â¨ ª®¬¯'îâ¥à"
},
{

View file

@ -4105,13 +4105,15 @@ BootLoaderHarddiskVbrPage(PINPUT_RECORD Ir)
{
NTSTATUS Status;
// FIXME! We must not use the partition type, but instead use the partition FileSystem!!
Status = InstallVBRToPartition(&USetupData.SystemRootPath,
&USetupData.SourceRootPath,
&USetupData.DestinationArcPath,
PartitionList->SystemPartition->PartitionType);
if (!NT_SUCCESS(Status))
{
MUIDisplayError(ERROR_WRITE_BOOT, Ir, POPUP_WAIT_ENTER);
MUIDisplayError(ERROR_WRITE_BOOT, Ir, POPUP_WAIT_ENTER,
PartitionList->SystemPartition->FileSystem->FileSystemName);
return QUIT_PAGE;
}
@ -4140,13 +4142,15 @@ BootLoaderHarddiskMbrPage(PINPUT_RECORD Ir)
WCHAR DestinationDevicePathBuffer[MAX_PATH];
/* Step 1: Write the VBR */
// FIXME! We must not use the partition type, but instead use the partition FileSystem!!
Status = InstallVBRToPartition(&USetupData.SystemRootPath,
&USetupData.SourceRootPath,
&USetupData.DestinationArcPath,
PartitionList->SystemPartition->PartitionType);
if (!NT_SUCCESS(Status))
{
MUIDisplayError(ERROR_WRITE_BOOT, Ir, POPUP_WAIT_ENTER);
MUIDisplayError(ERROR_WRITE_BOOT, Ir, POPUP_WAIT_ENTER,
PartitionList->SystemPartition->FileSystem->FileSystemName);
return QUIT_PAGE;
}
@ -4160,7 +4164,7 @@ BootLoaderHarddiskMbrPage(PINPUT_RECORD Ir)
if (!NT_SUCCESS(Status))
{
DPRINT1("InstallMbrBootCodeToDisk() failed (Status %lx)\n", Status);
MUIDisplayError(ERROR_INSTALL_BOOTCODE, Ir, POPUP_WAIT_ENTER);
MUIDisplayError(ERROR_INSTALL_BOOTCODE, Ir, POPUP_WAIT_ENTER, L"MBR");
return QUIT_PAGE;
}