Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-05-28 05:28:14 +00:00
Code Issues Projects Releases Packages Wiki Activity

[CONTROL] Fix hang while calling RunControlPanel() CORE-11373

Browse source 
- based on a patch by Jira user "wimh"
- also addressed Hermes' suggestion to use ARRAYSIZE instead of MAX_PATH
This commit is contained in:
Robert Naumann 2020-04-23 19:28:14 +02:00
parent e15746849a
commit 032b5aacd2
1 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
base/applications/control/control.c
View file

@ -57,18 +57,12 @@ OpenShellFolder(LPWSTR lpFolderCLSID)
static INT
RunControlPanel(LPCWSTR lpCmd)
{
/*
* Old method:
*
WCHAR szParameters[MAX_PATH];
wcscpy(szParameters, L"shell32.dll,Control_RunDLL ");
wcscat(szParameters, lpCmd);
return RUNDLL(szParameters);
*/
StringCchCopyW(szParameters, ARRAYSIZE(szParameters), L"shell32.dll,Control_RunDLL ");
if (FAILED(StringCchCatW(szParameters, ARRAYSIZE(szParameters), lpCmd)))
return 0;
/* New method: */
Control_RunDLLW(GetDesktopWindow(), 0, lpCmd, SW_SHOW);
return 1;
return RUNDLL(szParameters);
}
INT