Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-23 17:05:46 +00:00
Code Issues Projects Releases Packages Wiki Activity

[WIN32K]

Browse source 
- Add some debug prints helping diagnosing which GDI objects are locked when they should not be.
 - Plug a region (lock) leak
 - Remove some dead code.

svn path=/trunk/; revision=64226
This commit is contained in:
Jérôme Gardou 2014-09-22 14:33:06 +00:00
parent a9b289888e
commit 031ed04e0c
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
reactos/win32ss/gdi/ntgdi/gdidebug.h
View file

@ -80,8 +80,11 @@ GdiDbgAssertNoLocks(char * pszFile, ULONG nLine)
PTHREADINFO pti = (PTHREADINFO)PsGetCurrentThreadWin32Thread(); PTHREADINFO pti = (PTHREADINFO)PsGetCurrentThreadWin32Thread();
if (pti && pti->cExclusiveLocks != 0) if (pti && pti->cExclusiveLocks != 0)
{ {
ULONG i;
DbgPrint("(%s:%lu) There are %lu exclusive locks!\n", DbgPrint("(%s:%lu) There are %lu exclusive locks!\n",
pszFile, nLine, pti->cExclusiveLocks); pszFile, nLine, pti->cExclusiveLocks);
for (i = 0; i < (GDIObjTypeTotal + 1); i++)
DbgPrint(" Type %u: %u.\n", i, pti->acExclusiveLockCount[i]);
ASSERT(FALSE); ASSERT(FALSE);
} }
} }

4
reactos/win32ss/gdi/ntgdi/region.c
View file

@ -3847,10 +3847,6 @@ NtGdiPtInRegion(
RGNOBJAPI_Unlock(prgn); RGNOBJAPI_Unlock(prgn);
return ret; return ret;
RGNOBJAPI_Unlock(prgn);
return FALSE;
} }
BOOL BOOL

1
reactos/win32ss/user/ntuser/vis.c
View file

@ -116,6 +116,7 @@ VIS_ComputeVisibleRegion(
IntGdiOffsetRgn(ClipRgn, -CurrentWindow->rcWindow.left, -CurrentWindow->rcWindow.top); IntGdiOffsetRgn(ClipRgn, -CurrentWindow->rcWindow.left, -CurrentWindow->rcWindow.top);
IntGdiCombineRgn(ClipRgn, ClipRgn, CurrentRgnClip, RGN_AND); IntGdiCombineRgn(ClipRgn, ClipRgn, CurrentRgnClip, RGN_AND);
IntGdiOffsetRgn(ClipRgn, CurrentWindow->rcWindow.left, CurrentWindow->rcWindow.top); IntGdiOffsetRgn(ClipRgn, CurrentWindow->rcWindow.left, CurrentWindow->rcWindow.top);
RGNOBJAPI_Unlock(CurrentRgnClip);
} }
} }
IntGdiCombineRgn(VisRgn, VisRgn, ClipRgn, RGN_DIFF); IntGdiCombineRgn(VisRgn, VisRgn, ClipRgn, RGN_DIFF);